Require PHP 8, Symfony 5.4, PHPUnit 9.3. Allow Symfony 6. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjanssen
force-pushed
the
patch-1
branch
4 times, most recently
from
b165bc7
to
374b0f6
Compare
mattjanssen
changed the title
mattjanssen
force-pushed
the
patch-1
branch
6 times, most recently
from
264e70f
to
498f833
Compare
mattjanssen
changed the title
|
Here's the passing Travis CI: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to install Retrofit on Symfony v5.4 and v6, with PHP v8, which are the only maintained versions.
I'll probably spend some time in the next couple months adding support for PHP 8 features to Retrofit and Gson. Can I at the same time drop support for PHP 7? Symfony dropped PHP 7 support in 2021.