Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci #47

Merged
merged 4 commits into from
Jan 3, 2025
Merged

ci #47

merged 4 commits into from
Jan 3, 2025

Conversation

sanchitram1
Copy link
Member

@sanchitram1 sanchitram1 commented Jan 2, 2025

initial test infrastructure for CHAI

  • pytest markers organize the tests (see pytest.ini) and make execution easy
  • tests/requirements.txt will have test-specific dependencies
  • conftest.py for shared test fixtures and utilities
  • added pytest-cov for coverage reporting

currently, coverage is about 40% with the most on the models, and the least on db.py. fetcher and scheduler are untested

Notes for Contributors

  • Tests can be run locally using pytest with appropriate markers:
    • pytest -v -m transformer for transformer tests
    • pytest -v -m db for database tests
    • pytest -v -m system for system tests
  • Coverage reports can be generated using --cov=core flag
  • New tests should follow the established pattern in existing test files

@sanchitram1 sanchitram1 requested a review from jhheider January 2, 2025 23:23
@sanchitram1
Copy link
Member Author

seems like my CI worked @jhheider...thank you Claude

jhheider
jhheider previously approved these changes Jan 2, 2025
Copy link
Member

@jhheider jhheider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all testing is a worthy improvement.

.github/workflows/ci.yml Show resolved Hide resolved
@sanchitram1 sanchitram1 merged commit 5d1d2c6 into main Jan 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants