Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format code with black #13

Closed
zupo opened this issue Jul 26, 2018 · 1 comment
Closed

Format code with black #13

zupo opened this issue Jul 26, 2018 · 1 comment
Assignees
@ikolar

Comments

@zupo
Copy link
Member

zupo commented Jul 26, 2018

And add a Travis step to check that all code remains formatted.
ikolar added a commit that referenced this issue Jan 7, 2019
@ikolar
Added black to the [dev-packages] section in Pipfile.
134982c 
Also added a call to it in .travis.yml.  Not sure whether this is the
correct place, and this .travis.yml is quite different than the one in
woocart-api. Help appreciated.

Ref: #13
ikolar added a commit that referenced this issue Jan 8, 2019
@ikolar
Removed Pipfile additions not necessary for this issue (they belong to …
703e13f 
…#13).

Ref: #10
ikolar added a commit that referenced this issue Jan 8, 2019
@ikolar
Removed the call to black from .travis.yml (since it belongs to issue #…
baef42f 
…13).

Ref: #10
ikolar added a commit that referenced this issue Jan 9, 2019
@ikolar
Ran black manually, and checked its changed by running the tests. All…
9d2e40f 
… was good, commiting its changes.

Ref: #13
@ikolar ikolar mentioned this issue Jan 9, 2019
Merged
@ikolar
Copy link
Contributor

ikolar commented Jan 13, 2019

Added the missing --check to .travis.yml. Travis tests passed, merged.

Closing.

@ikolar ikolar closed this as completed Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikolar ikolar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ikolar @zupo