Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in Node 22 of Hanko not being a valid module
Description
In Node 22 the following error is generated when installing Hanko Elements:
You can try this out by:
brew install node@22
)npm create svelte@latest mytest
)npm install --save @teamhanko/hanko-elements
)npm run dev
)This is caused by the fact that HankoElements is not declared as an ESM module correctly. As Node.js is migrating away from CommonJS, this is a rather known bug in many packages. To fix this issue, you have two options:
.mjs
which will instruct Node.js to import files using ESMThe later however isn't really supported by browsers.
Tests
Updating the
package.json
of an installed Hanko Elements with the proposed diff "just works" and unbreaks builds.Additional context
I attached a vite_build.log log for reference.