Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filter per year for financial overview statistics #349

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

aghimpu
Copy link
Contributor

@aghimpu aghimpu commented Sep 29, 2024

Changes description & testing suggestions

Developers checklist

  • Check that dusk tests are working locally on compatible branch
  • Mobile version of changes is developed - if its a webshop feature, mobile version for this feature is developed

QA checklist

  • Check regress in implementations custom css - changes are not breaking other implementations designes
  • Feature is tested in different screen sizes - desktop, mobile
  • WCAG requirements are met - new feature is accessible by keyboard, there are an alt texts
  • Translations are done

@lexlog lexlog added the Urgency: Medium needs to be reviewed during sprint label Sep 30, 2024
@dev-rminds dev-rminds force-pushed the financial-overview-filter-statistics-per-year branch from 6ccfe6c to 1759d86 Compare October 8, 2024 15:30
@dev-rminds dev-rminds assigned aghimpu and unassigned dev-rminds Oct 9, 2024
@aghimpu aghimpu assigned dev-rminds and unassigned aghimpu Oct 11, 2024
@dev-rminds dev-rminds marked this pull request as ready for review October 23, 2024 08:12
Copy link
Contributor

@irinaBerendeeva87 irinaBerendeeva87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked: financieel-dashboard-overzicht

❌ dropdowns retains their states when changing implementation
❌ URL does not have a parameter when chosen different year

keepits.mov

Balance and expenses
✅ "Selecteer export type" modal
✅ dropdown
✅ hover
Tegoeden
✅ "Selecteer export type" modal

✅ dropdown
✅ hover
❌ incorrect data on the table(Nijmegen 2024/23 year)
Screenshot 2024-10-24 at 11 03 52

✅ checked in different implementations

@aghimpu
Copy link
Contributor Author

aghimpu commented Oct 29, 2024

Checked: financieel-dashboard-overzicht

❌ dropdowns retains their states when changing implementation

@irinaBerendeeva87 The dropdowns are not supposed to retain their state when changing the organization in our organization switcher. It's not implemented on other pages and it's hard to implement such a behavior just for this particular case.

I added a URL query parameter like requested though.

Copy link
Contributor

@irinaBerendeeva87 irinaBerendeeva87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked:

fixed

  • dropdowns retains their states when changing implementation
  • URL does not have a parameter when chosen different year
  • incorrect data on the table(Nijmegen 2024/23 year)
    Balance and expenses
    ✅ "Selecteer export type" modal
    ✅ dropdown
    ✅ hover

Tegoeden
❌ "Uitgaven " column in csv file and in the page has a different value
Screenshot 2024-10-30 at 15 32 28

❌ moving animation while changing year in dropdown

animation.2021-2020yesrs.mov

❌ all funds are displayed
Not all funds are displayed in Tegoeden in Groningen impl.
in DB there is 4 funds but displayed only one. in backend response there is also 4 funds
Screenshot 2024-10-31 at 10 56 49

Screenshot 2024-10-31 at 10 48 30

❓ Eemsdelta impl. has payouts in Tegoeden but download file without fund with type= payout

Screenshot 2024-10-31 at 11 39 05

✅ no errors in the console
✅ error 422
✅ checked in different implementations


Not related to this PR

@aghimpu
Copy link
Contributor Author

aghimpu commented Oct 31, 2024

@irinaBerendeeva87 in the second table we are displaying just the funds that have type = 'budget', so
"❌ all funds are displayed" isn't valid. So the funds being filtered based on that was done on purpose, it was always working like that.

@irinaBerendeeva87
Copy link
Contributor

@irinaBerendeeva87 in the second table we are displaying just the funds that have type = 'budget', so "❌ all funds are displayed" isn't valid. So the funds being filtered based on that was done on purpose, it was always working like that.

Thanks. I got it.

@aghimpu aghimpu assigned irinaBerendeeva87 and unassigned aghimpu Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Urgency: Medium needs to be reviewed during sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants