-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add filter per year for financial overview statistics #349
base: develop
Are you sure you want to change the base?
Conversation
6ccfe6c
to
1759d86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked: financieel-dashboard-overzicht
❌ dropdowns retains their states when changing implementation
❌ URL does not have a parameter when chosen different year
keepits.mov
Balance and expenses
✅ "Selecteer export type" modal
✅ dropdown
✅ hover
Tegoeden
✅ "Selecteer export type" modal
✅ dropdown
✅ hover
❌ incorrect data on the table(Nijmegen 2024/23 year)
✅ checked in different implementations
@irinaBerendeeva87 The dropdowns are not supposed to retain their state when changing the organization in our organization switcher. It's not implemented on other pages and it's hard to implement such a behavior just for this particular case. I added a URL query parameter like requested though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked:
fixed
- dropdowns retains their states when changing implementation
- URL does not have a parameter when chosen different year
- incorrect data on the table(Nijmegen 2024/23 year)
Balance and expenses
✅ "Selecteer export type" modal
✅ dropdown
✅ hover
Tegoeden
❌ "Uitgaven " column in csv file and in the page has a different value
❌ moving animation while changing year in dropdown
animation.2021-2020yesrs.mov
❌ all funds are displayed
Not all funds are displayed in Tegoeden in Groningen impl.
in DB there is 4 funds but displayed only one. in backend response there is also 4 funds
❓ Eemsdelta impl. has payouts in Tegoeden but download file without fund with type= payout
✅ no errors in the console
✅ error 422
✅ checked in different implementations
Not related to this PR
@irinaBerendeeva87 in the second table we are displaying just the funds that have type = 'budget', so |
Thanks. I got it. |
Changes description & testing suggestions
Developers checklist
QA checklist