Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements #41

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Minor improvements #41

merged 2 commits into from
Dec 18, 2023

Conversation

felix-datatonic
Copy link
Collaborator

Description

  • Prettify outputs in Makefile
  • Fix scripts and clarify authentication for Workbench users in docs/notebooks
  • Change naming of serving to prediction throughout code and docs

How has this been tested?

Successful unit and e2e tests.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (make test-trigger and make test-all-components)
  • I have successfully run the E2E tests
  • I have updated any relevant documentation to reflect my changes

@felix-datatonic
Copy link
Collaborator Author

/gcbrun

jgammon-dt
jgammon-dt approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@jgammon-dt jgammon-dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@felix-datatonic felix-datatonic merged commit 67ae120 into develop Dec 18, 2023
3 checks passed
@felix-datatonic felix-datatonic deleted the feat/tweaks branch December 20, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgammon-dt jgammon-dt jgammon-dt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felix-datatonic @jgammon-dt