Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make build target variable substitution #35

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

donatas-dt
Copy link
Collaborator

@donatas-dt donatas-dt commented Sep 5, 2023

Description

Target variable is not being substituted as expected

Before fix:
image

After fix:
image

How has this been tested?


Please explain how you have tested the new changes.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have successfully run the E2E tests, and have included the links to the pipeline runs below
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated any relevant documentation to reflect my changes
  • I have assigned a reviewer and messaged them

Pipeline run links:

@donatas-dt donatas-dt changed the title fix: make build variable substitution fix fix: make build target variable substitution Sep 5, 2023
@felix-datatonic
Copy link
Collaborator

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants