refactor: simplify make commands #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile
Outdated
Comment on lines
53
to
54
| targets ?= training serving | ||
| build: ## Build and push training/serving container image using Docker. Specify target=<training|serving> |
There was a problem hiding this comment.
target or targets?
There was a problem hiding this comment.
targets - it now accepts a list of targets so you can choose to build both training and serving containers with one command
There was a problem hiding this comment.
Suggested change
| targets ?= training serving | |
| build: ## Build and push training/serving container image using Docker. Specify target=<training|serving> | |
| targets ?= training serving | |
| build: ## Build and push training and/or serving container(s) image using Docker. Specify targets=<training serving> e.g. targets=training or targets=training serving (default) |
There was a problem hiding this comment.
I think it would need to be targets="training serving" (in quotes) to be interpreted correctly by the shell
ghost
reviewed
Aug 21, 2023
ghost
reviewed
Aug 21, 2023
Makefile
Outdated
| $(MAKE) test-components GROUP=$$(basename $$component_group) ; \ | ||
| done | ||
| targets ?= "training serving" | ||
| build: ## Build and push training and/or serving container(s) image using Docker. Specify targets=<training serving> e.g. targets=training or targets=training serving (default) |
There was a problem hiding this comment.
add quotes to the docstring as well e.g. targets=training or targets="training serving" (default)
ghost
suggested changes
Aug 22, 2023
|
/gcbrun |
ghost
self-requested a review
ghost
suggested changes
Aug 23, 2023
ghost
self-requested a review
6 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refines the make commands to be simpler and I have implemented this by merging old commands into new ones
Files updated are the Makefile and the cloudbuild files accordingly.
How has this been tested?
Please explain how you have tested the new changes.
Checklist
Pipeline run links: