Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RESOURCE_SUFFIX bug #27

Merged
merged 8 commits into from
Jul 5, 2023
Merged

Conversation

jan-zajac-dt
Copy link

Description

Fixing the RESOURCE_SUFFIX PR

How has this been tested?

Ran pipelines with and without RESOURCE_SUFFIX

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have successfully run the E2E tests, and have included the links to the pipeline runs below
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated any relevant documentation to reflect my changes
  • I have assigned a reviewer and messaged them

Pipeline run links:

https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/xgboost-train-pipeline-20230626211041?project=dt-jan-sandbox-dev

https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/xgboost-train-pipeline-20230626211101?project=dt-jan-sandbox-dev

@jan-zajac-dt jan-zajac-dt requested review from a user and felix-datatonic June 26, 2023 19:23
@jan-zajac-dt
Copy link
Author

/gcbrun

env.sh.example Outdated Show resolved Hide resolved
@jan-zajac-dt
Copy link
Author

/gcbrun

@jan-zajac-dt
Copy link
Author

/gcbrun

@jan-zajac-dt
Copy link
Author

/gcbrun

@jan-zajac-dt
Copy link
Author

/gcbrun

@jan-zajac-dt
Copy link
Author

/gcbrun

env.sh.example Outdated Show resolved Hide resolved
@jan-zajac-dt
Copy link
Author

/gcbrun

@felix-datatonic felix-datatonic merged commit 7721bcd into develop Jul 5, 2023
@felix-datatonic felix-datatonic deleted the feat/enable-concurrent-runs branch November 13, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants