Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return gcp resources #19

Merged
merged 6 commits into from
Jun 5, 2023
Merged

Conversation

donatas-dt
Copy link
Collaborator

@donatas-dt donatas-dt commented Jun 1, 2023

Description

Return gcp_resources in custom_train_job. Should allow to click "view custom job" in UI.
Relevant documentation: https://cloud.google.com/vertex-ai/docs/pipelines/build-own-components
image

How has this been tested?

make e2e-tests
make test-all-components
Tests in CICD

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have successfully run the E2E tests, and have included the links to the pipeline runs below
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated any relevant documentation to reflect my changes
  • I have assigned a reviewer and messaged them

Pipeline run links:

https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/tensorflow-prediction-pipeline-20230602085628?project=dt-turbo-templates-staging
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/xgboost-prediction-pipeline-20230602084746?project=dt-turbo-templates-staging
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/tensorflow-train-pipeline-20230602083603?project=dt-turbo-templates-staging
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/xgboost-train-pipeline-20230602083557?project=dt-turbo-templates-staging

@donatas-dt donatas-dt changed the title feat: return gcp resources (draft) feat: return gcp resources Jun 1, 2023
@donatas-dt

This comment was marked as outdated.

@donatas-dt
Copy link
Collaborator Author

/gcbrun

@donatas-dt donatas-dt marked this pull request as ready for review June 2, 2023 09:21
@felix-datatonic felix-datatonic force-pushed the features/gcp_resources branch from 47407eb to 15675d4 Compare June 2, 2023 19:53
@felix-datatonic
Copy link
Collaborator

/gcbrun

@ariadnafer
Copy link

lgtm!

@felix-datatonic felix-datatonic merged commit 44730dd into develop Jun 5, 2023
@felix-datatonic felix-datatonic deleted the features/gcp_resources branch November 13, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants