Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add tests #15

Merged
merged 3 commits into from
May 26, 2023
Merged

feature: add tests #15

merged 3 commits into from
May 26, 2023

Conversation

ariadnafer
Copy link

@ariadnafer ariadnafer commented May 22, 2023

Description

Added testing with coverage
Added tests for the following components:

  • extract_bq_to_dataset
  • custom_train_job
  • import_model_evaluation

How has this been tested?

This PR is for testing purposes itself

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have successfully run the E2E tests, and have included the links to the pipeline runs below
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated any relevant documentation to reflect my changes
  • I have assigned a reviewer and messaged them

Pipeline run links:

@ariadnafer ariadnafer changed the title Feature/add tests feature: add tests May 22, 2023
@ariadnafer ariadnafer requested review from a user and felix-datatonic May 22, 2023 13:20
Copy link
Collaborator

@felix-datatonic felix-datatonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ariadnafer! Have left a minor comment on formatting mock.patch, otherwise happy with improving the code coverage. Also, I'd remove inline comments as much as possible and only comment complex code blocks. Python code should aim for simplicity and self-explainability.

@ariadnafer
Copy link
Author

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants