Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: combine assets into a single folder #14

Merged
merged 20 commits into from
May 30, 2023
Merged

Conversation

donatas-dt
Copy link
Collaborator

@donatas-dt donatas-dt commented May 16, 2023

Description

Currently there are 4 assets folders - one for each pipeline.

I combined them into one assets folder used for all pipelines. Updated docs, makefile, CI/CD...

How has this been tested?

E2E tests in CI/CD
Release CI/CD tested in forked repo and new gcp projects.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have successfully run the E2E tests, and have included the links to the pipeline runs below
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated any relevant documentation to reflect my changes
  • I have assigned a reviewer and messaged them

Pipeline run links:

https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/tensorflow-prediction-pipeline-20230522091356?project=dt-turbo-templates-staging
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/xgboost-prediction-pipeline-20230522090420?project=dt-turbo-templates-staging
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/tensorflow-train-pipeline-20230522085148?project=dt-turbo-templates-staging
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/xgboost-train-pipeline-20230522085140?project=dt-turbo-templates-staging

@ghost ghost changed the base branch from main to develop May 17, 2023 13:10
@donatas-dt donatas-dt marked this pull request as ready for review May 23, 2023 14:16
@donatas-dt donatas-dt marked this pull request as draft May 23, 2023 14:20
@donatas-dt donatas-dt marked this pull request as ready for review May 23, 2023 15:31
@donatas-dt donatas-dt requested review from felix-datatonic and a user May 23, 2023 16:19
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
donatas-dt and others added 2 commits May 24, 2023 10:47
Co-authored-by: Felix Schaumann <[email protected]>
Co-authored-by: Felix Schaumann <[email protected]>
@teamdatatonic teamdatatonic deleted a comment from donatas-dt May 26, 2023
@teamdatatonic teamdatatonic deleted a comment from donatas-dt May 26, 2023
@teamdatatonic teamdatatonic deleted a comment from donatas-dt May 26, 2023
@teamdatatonic teamdatatonic deleted a comment from donatas-dt May 26, 2023
@teamdatatonic teamdatatonic deleted a comment from donatas-dt May 30, 2023
@donatas-dt
Copy link
Collaborator Author

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants