-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable multiquery #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
May 16, 2023
felix-datatonic
previously approved these changes
May 16, 2023
ghost
force-pushed
the
feature/enable-multiquery
branch
from
May 17, 2023 13:11
0b8b77f
to
299f834
Compare
ghost
suggested changes
May 20, 2023
ariadnafer
force-pushed
the
feature/enable-multiquery
branch
from
May 20, 2023 21:08
f53af72
to
e8b492f
Compare
/gcbrun |
felix-datatonic
approved these changes
May 22, 2023
ghost
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous custom components was not allowing running multi-queries in the same SQL file. This PR merges all the queries into a single SQL script and replace the custom component with the BigqueryQueryJobOp google component
How has this been tested?
Please explain how you have tested the new changes.
Checklist
Pipeline run links:
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/xgboost-train-pipeline-20230516134111?project=dt-turbo-templates-dev
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/xgboost-prediction-pipeline-20230516135109?project=dt-turbo-templates-dev
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/tensorflow-train-pipeline-20230516135752?project=dt-turbo-templates-dev
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/tensorflow-prediction-pipeline-20230516142755?project=dt-turbo-templates-dev