Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enable model monitoring #11

Merged
1 commit merged into from
May 17, 2023
Merged

Fix: Enable model monitoring #11

1 commit merged into from
May 17, 2023

Conversation

felix-datatonic
Copy link
Collaborator

@felix-datatonic felix-datatonic commented May 11, 2023

Description

Model monitoring metadata isn't persisted during XGBoost training. Further, caching has been disabled for lookup_model components in all pipelines.

How has this been tested?

  • clean model registry
  • end-to-end tests (with and without caching)
  • ensure that batch prediction jobs return monitoring results

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have successfully run the E2E tests, and have included the links to the pipeline runs below
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated any relevant documentation to reflect my changes
  • I have assigned a reviewer and messaged them

Pipeline run links:

@felix-datatonic felix-datatonic changed the title Fix/enable model monitoring Fix: enable model monitoring May 11, 2023
@felix-datatonic felix-datatonic changed the title Fix: enable model monitoring Fix: Enable model monitoring May 11, 2023
@felix-datatonic
Copy link
Collaborator Author

/gcbrun

@felix-datatonic felix-datatonic requested a review from a user May 11, 2023 09:03
@felix-datatonic felix-datatonic self-assigned this May 11, 2023
@felix-datatonic felix-datatonic added the bug Something isn't working label May 11, 2023
@ghost ghost changed the base branch from main to develop May 17, 2023 13:05
@ghost ghost force-pushed the fix/enable-model-monitoring branch from 542d954 to 034c440 Compare May 17, 2023 13:06
@ghost ghost merged commit 0a2f77a into develop May 17, 2023
@ghost ghost deleted the fix/enable-model-monitoring branch May 17, 2023 13:06
@ghost ghost restored the fix/enable-model-monitoring branch May 17, 2023 13:06
@felix-datatonic felix-datatonic deleted the fix/enable-model-monitoring branch November 13, 2023 17:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant