use Selenium::WebDriver::VERSION vs. Gem.loaded_v #2385
Conversation
This change switches a check against the version of `selenium-webdriver` to use the version number defined by the library itself instead of accessing it via Gem.loaded_version, as the latter relies on the gem being loaded via RubyGems a particular way that we happen to not be using at in the GitHub monolith :) Co-authored-by: Natasha Umer <[email protected]> Co-authored-by: John Crepezzi <[email protected]>
|
Unfortunately IIRC selenium-webdriver doesn't define Selenium::WebDriver::VERSION in the oldest versions we technically claim to support which is why this check was done the way it was. We could dump older versions of selenium-webdriver and only support versions which define their version, or this check needs to be more complicated and combine both methods. Either way it's not acceptable as currently submitted. |
|
@twalpole makes sense. I've rewritten the implementation to only use the constant if the |
|
@twalpole I'm having a hard time telling if any of the CI failures are legitimate. I don't believe they are. Can you confirm? ❤️ |
|
They don't appear to be related to this -- seems more like a FF version update has broken a few things. |
This change switches a check against the version
of
selenium-webdriverto use the version numberdefined by the library itself instead of accessing
it via
Gem.loaded_version, as the latter relieson the gem being loaded via RubyGems a particular
way that we happen to not be using at in the
Github monolith :)
Co-authored-by: Natasha Umer [email protected]
Co-authored-by: John Crepezzi [email protected]