chore: replace mocha-circleci-reporter with mocha-multi-reporters
#8845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luvkapur
changed the title
mocha-circleci-reporter with mocha-junit-reporter
GiladShoham
reviewed
May 1, 2024
.circleci/config.yml
Outdated
| # command which support only - for debug purpose | ||
| # command: cd bit && npm run e2e-test-circle --debug | ||
| environment: | ||
| MOCHA_FILE: junit/e2e-test-results.xml | ||
| NODE_OPTIONS: --no-warnings --max-old-space-size=5000 | ||
| # NODE_OPTIONS: --no-warnings --max-old-space-size=5000 |
There was a problem hiding this comment.
@luvkapur why did you remove also the max old space?
There was a problem hiding this comment.
@GiladShoham
because I saw we pass it as part of the script for this command
mocha-circleci": "cross-env NODE_OPTIONS='--no-warnings --max-old-space-size=5000'
I see it is missing here for the e2e-test-circle cmd which I overlooked
e2e-test-circle": "cross-env NODE_OPTIONS=--no-warnings
i will add it there and then we dont need it as part of config.yml since it is redundant
luvkapur
changed the title
mocha-circleci-reporter with mocha-junit-reportermocha-circleci-reporter with mocha-multi-reporters
davidfirst
approved these changes
May 1, 2024
davidfirst
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
mocha-circleci-reporter(https://github.com/sandcastle/mocha-circleci-reporter) which is no longer maintained and has a security vulnerability withmocha-multi-reporters, that usesmocha-junit-reporterto output to xml andspecto output to console.