Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compare): make component compare context single instance at runtime #8809

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix(compare): make component compare context single instance at runtime #8809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a675ee2
make component compare context single instance at runtime
luvkapur Apr 22, 2024
2698e92
make component compare context single instance at runtime
luvkapur Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scopes/ui-foundation/ui/webpack/webpack.base.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ export default function createWebpackConfig(
'react-dom$': 'react-dom/profiling',
'scheduler/tracing': 'scheduler/tracing-profiling',
}),
'@teambit/component.ui.component-compare.context': require.resolve(
'@teambit/component.ui.component-compare.context'
),
},
fallback: {
module: false,
Expand Down
3 changes: 3 additions & 0 deletions scopes/ui-foundation/ui/webpack/webpack.dev.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,9 @@ export function devConfig(workspaceDir, entryFiles, title): WebpackConfigWithDev
react: require.resolve('react'),
'react-dom/server': require.resolve('react-dom/server'),
'react-dom': require.resolve('react-dom'),
'@teambit/component.ui.component-compare.context': require.resolve(
'@teambit/component.ui.component-compare.context'
),
// 'react-refresh/runtime': require.resolve('react-refresh/runtime'),
},
fallback: {
Expand Down