refactor, move dependents command from legacy to dependencies aspect (#…

…8983)
teambit · Jun 28, 2024 · c23e218 · c23e218
1 parent c081b5e
commit c23e218
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 19 deletions.
diff --git a/scopes/dependencies/dependencies/dependencies.main.runtime.ts b/scopes/dependencies/dependencies/dependencies.main.runtime.ts
@@ -37,6 +37,7 @@ import {
 } from './dependencies-cmd';
 import { DependenciesAspect } from './dependencies.aspect';
 import { DebugDependencies } from './dependencies-loader/auto-detect-deps';
+import { DependentsCmd } from './dependents-cmd';
 
 export type RemoveDependencyResult = { id: ComponentID; removedPackages: string[] };
 export type SetDependenciesResult = { changedComps: string[]; addedPackages: Record<string, string> };
@@ -410,7 +411,13 @@ export class DependenciesMain {
       new DependenciesBlameCmd(depsMain),
       new DependenciesUsageCmd(depsMain),
     ];
-    cli.register(depsCmd, new WhyCmd(depsMain), new SetPeerCmd(depsMain), new UnsetPeerCmd(depsMain));
+    cli.register(
+      depsCmd,
+      new WhyCmd(depsMain),
+      new SetPeerCmd(depsMain),
+      new UnsetPeerCmd(depsMain),
+      new DependentsCmd()
+    );
 
     ComponentLoader.loadDeps = depsMain.loadDependencies.bind(depsMain);
 

diff --git a/...li/commands/public-cmds/dependents-cmd.ts → ...pendencies/dependencies/dependents-cmd.ts b/...li/commands/public-cmds/dependents-cmd.ts → ...pendencies/dependencies/dependents-cmd.ts
@@ -1,28 +1,24 @@
 import chalk from 'chalk';
-import { dependents, DependentsResults } from '../../../api/consumer/lib/dependents';
-import { Group } from '../../command-groups';
-import { CommandOptions, LegacyCommand } from '../../legacy-command';
-import { generateDependentsInfoTable } from '../../templates/component-template';
+import { Command, CommandOptions } from '@teambit/cli';
+import { dependents, DependentsResults } from './dependents';
+import { generateDependentsInfoTable } from '@teambit/legacy/dist/cli/templates/component-template';
 
-export default class Dependents implements LegacyCommand {
+export class DependentsCmd implements Command {
   name = 'dependents <component-name>';
   helpUrl = 'reference/dependencies/inspecting-dependencies#review-dependents';
   arguments = [
     {
-      names: 'component-name',
+      name: 'component-name',
       description: 'component name or component id',
     },
   ];
   description = 'show dependents of the given component';
-  group: Group = 'info';
+  group = 'info';
   alias = '';
-  opts = [] as CommandOptions;
+  options = [] as CommandOptions;
 
-  action([id]: [string]): Promise<any> {
-    return dependents(id);
-  }
-
-  report(results: DependentsResults): string {
+  async report([id]: [string]) {
+    const results: DependentsResults = await dependents(id);
     if (!results.scopeDependents.length && !results.workspaceDependents.length) {
       return `no dependents found for ${results.id.toString()}.
 try running "bit cat-component ${results.id.toStringWithoutVersion()}" to see whether the component/version exists locally`;

diff --git a/src/api/consumer/lib/dependents.ts → ...s/dependencies/dependencies/dependents.ts b/src/api/consumer/lib/dependents.ts → ...s/dependencies/dependencies/dependents.ts
@@ -1,8 +1,8 @@
 import { ComponentID } from '@teambit/component-id';
 import { BitError } from '@teambit/bit-error';
-import { loadConsumerIfExist, Consumer } from '../../../consumer';
-import ConsumerNotFound from '../../../consumer/exceptions/consumer-not-found';
-import DependencyGraph, { DependenciesInfo } from '../../../scope/graph/scope-graph';
+import { loadConsumerIfExist, Consumer } from '@teambit/legacy/dist/consumer';
+import ConsumerNotFound from '@teambit/legacy/dist/consumer/exceptions/consumer-not-found';
+import DependencyGraph, { DependenciesInfo } from '@teambit/legacy/dist/scope/graph/scope-graph';
 
 export type DependentsResults = {
   scopeDependents: DependenciesInfo[];

diff --git a/src/cli/command-registry-builder.ts b/src/cli/command-registry-builder.ts
@@ -6,7 +6,6 @@ import CatLane from './commands/private-cmds/cat-lane-cmd';
 import CatObject from './commands/private-cmds/cat-object-cmd';
 import CatScope from './commands/private-cmds/cat-scope-cmd';
 import Config from './commands/public-cmds/config-cmd';
-import Dependents from './commands/public-cmds/dependents-cmd';
 import Remote from './commands/public-cmds/remote-cmd';
 import ScopeConfig from './commands/public-cmds/scope-config-cmd';
 import RunAction from './commands/private-cmds/run-action.cmd';
@@ -18,7 +17,6 @@ export default function registerCommands(): CommandRegistry {
     new CatObject(),
     new CatComponent(),
     new CatLane(),
-    new Dependents(),
     new CatScope(),
     new CatVersionHistoryCmd(),
     new ScopeConfig(),