Bug/improve build errors (#2051)

* better handle external errors from compilers
* upgrade serialize-error ^2.1.0 -> ^5.0.0
* remove deserialize-error (it's now part of serialize-error)
* related to #2023

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ## [unreleased]
 
 - [#2019](https://github.com/teambit/bit/issues/2019) fix `bit import --merge` to not override changed dependencies
+- [#2023](https://github.com/teambit/bit/issues/2023) better handle external errors from compilers
 
 ## [14.4.1-dev.1] - 2019-09-27
 

package.json

@@ -90,7 +90,6 @@
     "comment-json": "^1.1.3",
     "debug": "^4.1.1",
     "decamelize": "^1.2.0",
-    "deserialize-error": "0.0.3",
     "detect-indent": "^5.0.0",
     "detect-newline": "^3.0.0",
     "doctrine": "^2.0.2",
@@ -144,7 +143,7 @@
     "regenerator-runtime": "^0.11.0",
     "requestify": "^0.2.5",
     "semver": "^5.4.1",
-    "serialize-error": "^2.1.0",
+    "serialize-error": "^5.0.0",
     "ssh2": "^0.5.4",
     "string-format": "^0.5.0",
     "stringify-package": "^1.0.0",

src/analytics/analytics.js

@@ -1,5 +1,5 @@
 /** @flow */
-import serializeError from 'serialize-error';
+import { serializeError } from 'serialize-error';
 import path from 'path';
 import hashObj from 'object-hash';
 import uniqid from 'uniqid';

src/cli/command-registrar.js

@@ -1,5 +1,5 @@
 /** @flow */
-import serializeError from 'serialize-error';
+import { serializeError } from 'serialize-error';
 import R from 'ramda';
 import commander from 'commander';
 import chalk from 'chalk';

src/consumer/component-ops/build-component.js

@@ -396,7 +396,10 @@ const _runBuild = async ({
         logger.info(`build-components, deleting ${tmpFolderFullPath}`);
         fs.removeSync(tmpFolderFullPath);
       }
-      const errors = e.errors || [e];
+      // Some time an external tool might return a complex object or an array of errors
+      // See for example this issue: https://github.com/teambit/bit/issues/2023#issuecomment-534952085
+      // (The Vue compiler will return an object with different fields such as details, missing, origin, dependencies, module, name, error)
+      const errors = e.errors || (e.error ? [e.error] : [e]);
       const err = new ExternalBuildErrors(component.id.toString(), errors);
       throw err;
     });

src/logger/logger.js

@@ -1,7 +1,7 @@
 /** @flow */
 import chalk from 'chalk';
 import yn from 'yn';
-import serializeError from 'serialize-error';
+import { serializeError } from 'serialize-error';
 import format from 'string-format';
 import winston from 'winston';
 import path from 'path';

src/scope/ci-ops/run-and-update-ci.js

@@ -1,5 +1,5 @@
 /** @flow */
-import serializeError from 'serialize-error';
+import { serializeError } from 'serialize-error';
 import { buildInScope, testInScope, modifyCIProps } from '../../api/scope';
 
 async function runAndUpdateCI({

src/specs-runner/specs-runner.js

@@ -3,7 +3,7 @@ import R from 'ramda';
 import path from 'path';
 import execa from 'execa';
 import pEvent from 'p-event';
-import deserializeError from 'deserialize-error';
+import { deserializeError } from 'serialize-error';
 import { Results } from '../consumer/specs-results';
 import type { ForkLevel } from '../api/consumer/lib/test';
 import { TESTS_FORK_LEVEL } from '../constants';

src/specs-runner/worker.js

@@ -1,6 +1,6 @@
 // @flow
 // TODO - move to language specific driver.
-import serializeError from 'serialize-error';
+import { serializeError } from 'serialize-error';
 import { testInProcess } from '../api/consumer/lib/test';
 import loader from '../cli/loader';
 import ExternalErrors from '../error/external-errors';