fix dependency resolution of `.` and `..` to not be identified as custom-resolved used #105

davidfirst · 2019-06-14T14:03:59Z

Fixes teambit/bit#1734 by the following:

when the dependency is . or .., do not try to resolve it with the custom-module-resolution.
do not let dependency-tree guess when custom-resolve was used by filing-cabinet. Instead, the filing-cabinet declares once custom-module-resolution was used.

This change is

…hs, also, avoid assuming that custom-resolve was used only based on the relative-path and the existence of the config. instead, explicitly mark custom-resolved as such.

davidfirst added 4 commits June 13, 2019 17:12

fix teambit/bit#1734, recognize "." and ".." partials as relative pat…

a187d4f

…hs, also, avoid assuming that custom-resolve was used only based on the relative-path and the existence of the config. instead, explicitly mark custom-resolved as such.

fix custom-resolve for Vue files

895fddb

fix tests

a2d86f5

bump version

a95e0d3

davidfirst merged commit aee2d36 into master Jun 14, 2019

davidfirst deleted the issue/#1734 branch June 14, 2019 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix dependency resolution of `.` and `..` to not be identified as custom-resolved used #105

fix dependency resolution of `.` and `..` to not be identified as custom-resolved used #105

davidfirst commented Jun 14, 2019 •

edited by GiladShoham

Loading

fix dependency resolution of . and .. to not be identified as custom-resolved used #105

fix dependency resolution of . and .. to not be identified as custom-resolved used #105

Conversation

davidfirst commented Jun 14, 2019 • edited by GiladShoham Loading

fix dependency resolution of `.` and `..` to not be identified as custom-resolved used #105

fix dependency resolution of `.` and `..` to not be identified as custom-resolved used #105

davidfirst commented Jun 14, 2019 •

edited by GiladShoham

Loading