feature: 구인 게시글 CRUD 구현 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
daeundada
commented
Jun 12, 2024
daeundada
commented
- 구인 게시글 생성, 수정시 글과 함께 S3에 이미지 업로드가 가능하도록 구현했습니다.
- jobStartDate, jobEndDate 은 연-월-일 만 받아오는 값입니다. 불필요한 정보가 담긴 LocalDateTime이 아니라 LocalDate 으로 받아오도록 설정했습니다.
- 구인 게시글 전체 조회, 단건 조회를 구현했습니다.
- 구인 게시글 삭제시 S3에 이미지도 자동으로 삭제하는 로직을 구현했습니다.
- 이미지 정보는 BoardImage 엔티티와 레포지토리에서 따로 관리하도록 분리 했습니다.
EUNCHAEv1006
approved these changes
Jun 12, 2024
| @@ -34,6 +34,9 @@ dependencies { | |||
| // Springdoc OpenAPI | |||
| implementation 'org.springdoc:springdoc-openapi-starter-webmvc-ui:2.1.0' | |||
|
|
|||
| // S3 | |||
| implementation 'org.springframework.cloud:spring-cloud-starter-aws:2.2.6.RELEASE' | |||
There was a problem hiding this comment.
코드가 일관된 스타일이라 깔끔하네요.
다만, 나중에 스웨거를 추가해주시는 것이 좋을 듯 합니다.
|
|
||
| private Integer salaryAmount; | ||
|
|
||
| private String sex; |
There was a problem hiding this comment.
성별을 String으로 받으셨네요.
트렌디하십니다.
|
|
||
| private String jobContent; | ||
|
|
||
| private LocalDate jobStartDate; |
There was a problem hiding this comment.
날짜 필드에 @FutureOrPresent와 같은 유효성 검사를 추가하는 것이 어떨까요?
There was a problem hiding this comment.
좋은 의견 인 것 같습니다. 수정 했습니다.🐈⬛
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.