Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix events not processed when version equals to stored #824

Merged
merged 21 commits into from
Feb 28, 2024
Merged

Fix events not processed when version equals to stored #824

merged 21 commits into from
Feb 28, 2024

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Jan 30, 2024 •
edited by SleepySquash
Loading

Synopsis

Иногда может произойти ситуация когда в плашке чата будет писать что есть непрочитанные сообщения но в самом чате непрочитанных сообщений не будет.

Solution

Проблема будет исправлена.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Jan 30, 2024
@krida2000 krida2000 added this to the 0.1.0-alpha.12 milestone Jan 30, 2024
@krida2000 krida2000 self-assigned this Jan 30, 2024
@krida2000 krida2000 changed the title Fix messages might stuck at last, not loading the rest Fix messages might stuck at last, not loading the rest (#691) Jan 30, 2024
@krida2000
Copy link
Contributor Author

krida2000 commented Jan 30, 2024 •
edited by SleepySquash
Loading

FCM

Fix `EventChatFavorited` events being sometimes ignored in `ChatRepository` (#824)

Additionally:
- refactor stores to process events with equal versions

krida2000
krida2000 commented Jan 30, 2024
View reviewed changes
lib/store/chat_rx.dart Outdated Show resolved Hide resolved
@krida2000 krida2000 marked this pull request as ready for review January 31, 2024 12:00
SleepySquash
SleepySquash requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, отпишите мысли, пожалуйста, плюс если не возражаете, давайте Е2Е тест набросаем, в теории он несложный должен быть.

lib/store/chat.dart Outdated Show resolved Hide resolved
lib/store/chat.dart Outdated Show resolved Hide resolved
lib/store/chat.dart Show resolved Hide resolved
@SleepySquash SleepySquash added this to the 0.1.0-alpha.13 milestone Feb 23, 2024
SleepySquash
SleepySquash requested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, не забывайте про FCM и название PR. Этот PR решает далеко не ту задачу, которую Вы в FCM и в заголовке прописали.

lib/store/my_user.dart Outdated Show resolved Hide resolved
test/e2e/features/chat/favorite/.feature Outdated Show resolved Hide resolved
@krida2000 krida2000 changed the title Fix messages might stuck at last, not loading the rest (#691) Fix events not processed when version equals to stored Feb 27, 2024
@SleepySquash SleepySquash added k::refactor Refactor changes of existing code and removed k::UI/UX UI (user interface) and UX (user experience) changes labels Feb 28, 2024
@SleepySquash SleepySquash enabled auto-merge (squash) February 28, 2024 10:05
@SleepySquash SleepySquash merged commit 8fd9130 into main Feb 28, 2024
19 of 20 checks passed
@SleepySquash SleepySquash deleted the 691-fix-messages-not-loading branch February 28, 2024 10:18
github-actions bot added a commit that referenced this pull request Feb 28, 2024
@github-actions
Fix EventChatFavorited events being sometimes ignored in `ChatRepos…
56881e7 
…itory` (#824)

Additionally:
- refactor stores to process events with equal versions 8fd9130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code
Projects
Roadmap
Status: Done
Milestone
0.1.0-alpha.13
Development

Successfully merging this pull request may close these issues.
2 participants
@krida2000 @SleepySquash