Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag-n-drop Attachments (#594) #1140

Merged
merged 15 commits into from
Nov 18, 2024
Merged

Drag-n-drop Attachments (#594) #1140

merged 15 commits into from
Nov 18, 2024

Conversation

pratham-sarankar
Copy link
Contributor

@pratham-sarankar pratham-sarankar commented Nov 6, 2024 •
edited by SleepySquash
Loading

Resolves #594

Synopsis

Implement drag-n-drop for Attachments on Chats tab

Solution

The implementation will use super_drag_and_drop package to detect drag-n-drop of a file and existing mechanism for sending.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix feature New feature or request k::UI/UX UI (user interface) and UX (user experience) changes labels Nov 7, 2024
@SleepySquash SleepySquash added this to the 0.3.0 milestone Nov 7, 2024
@SleepySquash
Copy link
Contributor

@pratham-sarankar,

[x] Draft mode is removed

But it's not removed.

@pratham-sarankar pratham-sarankar marked this pull request as ready for review November 10, 2024 20:11
SleepySquash
SleepySquash requested changes Nov 11, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/widget/custom_drop_target.dart Show resolved Hide resolved
SleepySquash
SleepySquash requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pratham-sarankar, some comments duplicate the ones left in the previous reviews of the #1130.

lib/ui/page/home/tab/chats/widget/recent_chat.dart Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/widget/custom_drop_target.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/widget/recent_chat.dart Outdated Show resolved Hide resolved
lib/ui/page/home/widget/chat_tile.dart Outdated Show resolved Hide resolved
lib/util/data_reader.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/controller.dart Outdated Show resolved Hide resolved
@SleepySquash
Copy link
Contributor

FCM

Use `CustomDropTarget` in `RecentChatTile` to upload dragged `Attachment`s (#1140, #594)

- refactor `CustomDropTarget` to use `super_drag_and_drop` instead of `desktop_drop`

SleepySquash
SleepySquash approved these changes Nov 18, 2024
View reviewed changes
lib/ui/page/home/tab/chats/widget/recent_chat.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/widget/recent_chat.dart Show resolved Hide resolved
lib/ui/page/home/tab/chats/controller.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash merged commit 3033430 into team113:main Nov 18, 2024
19 of 26 checks passed
github-actions bot added a commit that referenced this pull request Nov 18, 2024
@github-actions
Use CustomDropTarget in RecentChatTile to upload dragged `Attachm…
9c4d055 
…ent`s (#1140, #594)

- refactor `CustomDropTarget` to use `super_drag_and_drop` instead of `desktop_drop`

Co-authored-by: SleepySquash <[email protected]> 3033430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@pratham-sarankar pratham-sarankar

Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

[$100] Implement drag-n-drop for Attachments on Chats tab
2 participants
@pratham-sarankar @SleepySquash