Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaw in memory belief #56

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: flaw in memory belief #56

merged 1 commit into from
May 29, 2024

Conversation

joachimdekker
Copy link
Contributor

General

This PR fixes a major flaw in the memory belief.

Testability

Run the tests and just approve 😉

Checklist

  • Set the proper pull request name
  • Merged main into your branch

Copy link

Copy link
Contributor

@Tboefijn Tboefijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR

flaw

@joachimdekker joachimdekker merged commit 67183a4 into dev May 29, 2024
2 checks passed
@joachimdekker joachimdekker deleted the fix/memory-belief-error branch May 29, 2024 18:36
Copy link

🎉 This PR is included in version 1.11.0-dev.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jun 5, 2024

🎉 This PR is included in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jun 5, 2024

🎉 This PR is included in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants