Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add combinators #55

Merged
merged 10 commits into from
Jun 3, 2024
Merged

feat: add combinators #55

merged 10 commits into from
Jun 3, 2024

Conversation

LukaBerkers
Copy link
Contributor

Description

This PR adds static methods which are wrappers around the constructors of goal structures and tactics, so the user does not have to write new every time.

The user should now be able to create a snippet looking something like this:

GoalStructure gs = FirstOf(Primitive(...));
Tactic t = FirstOf(AnyOf(...), AnyOf(...));

Checklist

  • Set the proper pull request name
  • Merged main into your branch

@LukaBerkers LukaBerkers changed the base branch from main to dev May 29, 2024 13:23
joachimdekker
joachimdekker previously approved these changes May 29, 2024
@LukaBerkers LukaBerkers force-pushed the feat/AP-104-combinators branch from 00fff66 to 92be0cf Compare May 29, 2024 16:57
joachimdekker
joachimdekker previously approved these changes May 29, 2024
Copy link
Contributor

@joachimdekker joachimdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please listen to this masterpiece

@joachimdekker joachimdekker marked this pull request as ready for review May 29, 2024 18:55
@LukaBerkers LukaBerkers changed the title feat: combinators feat: add combinators May 31, 2024
joachimdekker
joachimdekker previously approved these changes Jun 3, 2024
JensSteenmetz
JensSteenmetz previously approved these changes Jun 3, 2024
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reaction to the tests:
image

/// </summary>
public static class Combinators
{
#region GoalSructure combinators
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Suggested change
#region GoalSructure combinators
#region GoalStructure combinators

@LukaBerkers LukaBerkers dismissed stale reviews from JensSteenmetz and joachimdekker via acc4294 June 3, 2024 12:32
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukaBerkers LukaBerkers enabled auto-merge (squash) June 3, 2024 12:35
@LukaBerkers LukaBerkers merged commit 695b9c0 into dev Jun 3, 2024
1 check passed
@LukaBerkers LukaBerkers deleted the feat/AP-104-combinators branch June 3, 2024 12:36
Copy link

sonarqubecloud bot commented Jun 3, 2024

Copy link

github-actions bot commented Jun 3, 2024

🎉 This PR is included in version 1.11.0-dev.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jun 5, 2024

🎉 This PR is included in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jun 5, 2024

🎉 This PR is included in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants