feat: replace CircularArray with ExposedQueue #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ray-to-exposedQueue
…ray-to-exposedQueue
JensSteenmetz
changed the title
joachimdekker
requested changes
May 13, 2024
JensSteenmetz
changed the title
JensSteenmetz
requested changes
May 15, 2024
move private method, remove debug log, add exception check. work in progress commit so I can work on it on my PC
added exceptions and comments, moved some code, removed remove
joachimdekker
requested changes
May 15, 2024
also added/improved tests and resolved some PR feedback
…ray-to-exposedQueue
JoenvandeVorle
dismissed stale reviews from joachimdekker and JensSteenmetz
via
94836cc
|
joachimdekker
approved these changes
May 27, 2024
|
🎉 This PR is included in version 1.11.0-dev.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the MemoryBelief to use an exposed queue instead of a circular array.
Testability
Run the unit tests in
ExposedQueueTestsandMemoryBeliefTests.Checklist