Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sonarcloud #3

Merged
merged 17 commits into from
Feb 19, 2024
Merged

Add Sonarcloud #3

merged 17 commits into from
Feb 19, 2024

Conversation

joachimdekker
Copy link
Contributor

This PR proposes to add Sonarcloud to the build pipeline. I have no idea how GitHub Actions work, so I just pasted the pipeline provided by Sonarcloud and added the dotnet commands.

@QuakeEye, please review it 🙏

@joachimdekker joachimdekker self-assigned this Feb 12, 2024
SilasPeters
SilasPeters previously approved these changes Feb 13, 2024
Copy link
Collaborator

@SSelinn SSelinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

Aplib.Core/Main.cs Outdated Show resolved Hide resolved
Aplib.Core/Main.cs Outdated Show resolved Hide resolved
Aplib.Core/Main.cs Outdated Show resolved Hide resolved
Aplib.Tests/Aplib.Tests.csproj Show resolved Hide resolved
Aplib.Tests/SonarTest.cs Show resolved Hide resolved
SilasPeters
SilasPeters previously approved these changes Feb 13, 2024
Copy link
Contributor

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/pr-build.yml Show resolved Hide resolved
.github/workflows/pr-build.yml Outdated Show resolved Hide resolved
.github/workflows/pr-build.yml Outdated Show resolved Hide resolved
.github/workflows/pr-build.yml Outdated Show resolved Hide resolved
@joachimdekker joachimdekker enabled auto-merge (squash) February 19, 2024 09:23
Copy link

Copy link
Contributor

@QuakeEye QuakeEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@QuakeEye QuakeEye dismissed SSelinn’s stale review February 19, 2024 09:41

Review no longer necessary, approppiate amount of reviewers have approved.

@joachimdekker joachimdekker merged commit 0771315 into main Feb 19, 2024
2 checks passed
@QuakeEye QuakeEye deleted the cicd/0002-add-sonar branch February 19, 2024 09:41
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants