Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GoalStructure #25

Merged
merged 19 commits into from
Apr 1, 2024
Merged

feat: add GoalStructure #25

merged 19 commits into from
Apr 1, 2024

Conversation

SilasPeters
Copy link
Contributor

No description provided.

@joachimdekker joachimdekker self-assigned this Mar 30, 2024
@joachimdekker joachimdekker marked this pull request as ready for review March 30, 2024 23:12
@JensSteenmetz JensSteenmetz changed the title feat: goal structure feat: add GoalStructure Mar 31, 2024
@JensSteenmetz JensSteenmetz self-assigned this Apr 1, 2024
joachimdekker
joachimdekker previously approved these changes Apr 1, 2024
Copy link
Contributor

@joachimdekker joachimdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Jens approved my changes, and I approve Jens' changes)

Copy link
Contributor

@Tboefijn Tboefijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left some small suggestions.

Aplib.Core/Desire/Goals/IGoal.cs Outdated Show resolved Hide resolved
Aplib.Core/Desire/IGoalStructure.cs Outdated Show resolved Hide resolved
Aplib.Core/Desire/Goals/Goal.cs Outdated Show resolved Hide resolved
Aplib.Core/Desire/Goals/Goal.cs Outdated Show resolved Hide resolved
Co-authored-by: Thijs Boerefijn <[email protected]>
JensSteenmetz
JensSteenmetz previously approved these changes Apr 1, 2024
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Tboefijn Tboefijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more suggestions.

Aplib.Core/Desire/Goals/IGoal.cs Outdated Show resolved Hide resolved
Aplib.Core/Desire/Goals/Goal.cs Outdated Show resolved Hide resolved
Co-authored-by: Thijs Boerefijn <[email protected]>
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Tboefijn Tboefijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit messages could be a little bit more professional.

Copy link

sonarqubecloud bot commented Apr 1, 2024

@JensSteenmetz JensSteenmetz merged commit 33ea7e2 into main Apr 1, 2024
2 checks passed
@JensSteenmetz JensSteenmetz deleted the feat/0005-Goal-structure branch April 1, 2024 13:41
Copy link

github-actions bot commented Apr 1, 2024

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants