Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add additional rules for _fieldExample #23

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

SSelinn
Copy link
Collaborator

@SSelinn SSelinn commented Mar 26, 2024

Added additional rules to make _fieldExample not a warning but the default for internal, private, and protected_internal settings.

Copy link
Contributor

@Tboefijn Tboefijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You missed one space.

.editorconfig Outdated Show resolved Hide resolved
Copy link
Contributor

@Tboefijn Tboefijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@QuakeEye QuakeEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@SSelinn SSelinn merged commit dc07266 into main Mar 26, 2024
2 checks passed
@SSelinn SSelinn deleted the chore/16-Update-.editorconfig branch March 26, 2024 11:06
Copy link

github-actions bot commented Apr 1, 2024

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants