Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Belief and BeliefSet #21

Merged
merged 24 commits into from
Mar 26, 2024
Merged

feat: add Belief and BeliefSet #21

merged 24 commits into from
Mar 26, 2024

Conversation

JensSteenmetz
Copy link
Member

@JensSteenmetz JensSteenmetz commented Mar 18, 2024 •
edited
Loading

This PR proposes to add the basic functionality of the Belief and BeliefSet classes. A Belief/BeliefSet history is not stored yet. This PR aims to help get the aplib foundation working.

joachimdekker
joachimdekker previously approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@joachimdekker joachimdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left some few remarks, but overall good code!

Aplib.Core/Belief/Belief.cs Outdated Show resolved Hide resolved
Aplib.Core/Belief/Belief.cs Show resolved Hide resolved
Aplib.Core/Belief/Beliefset.cs Outdated Show resolved Hide resolved
@JensSteenmetz JensSteenmetz force-pushed the feat/100-beliefset-necessities branch from 670931a to 335d767 Compare March 18, 2024 23:11
@JensSteenmetz JensSteenmetz enabled auto-merge (squash) March 18, 2024 23:26
@JensSteenmetz JensSteenmetz disabled auto-merge March 18, 2024 23:26
@JensSteenmetz JensSteenmetz enabled auto-merge (squash) March 18, 2024 23:27
@JensSteenmetz JensSteenmetz disabled auto-merge March 18, 2024 23:27
@JensSteenmetz JensSteenmetz enabled auto-merge (squash) March 18, 2024 23:27
@JensSteenmetz JensSteenmetz disabled auto-merge March 18, 2024 23:35
@JensSteenmetz JensSteenmetz enabled auto-merge (squash) March 18, 2024 23:35
QuakeEye
QuakeEye requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@QuakeEye QuakeEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build fails due to non-recursive rename, check the logs, there is 1 location that needs fixing

joachimdekker
joachimdekker previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@joachimdekker joachimdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from one build error, but that is a tiny mistake.

@SilasPeters SilasPeters changed the title feat: add Belief and Beliefset feat: add Belief and BeliefSet Mar 21, 2024
@JensSteenmetz JensSteenmetz disabled auto-merge March 21, 2024 11:29
@JensSteenmetz JensSteenmetz force-pushed the feat/100-beliefset-necessities branch from 9502434 to e701cef Compare March 21, 2024 11:38
@JensSteenmetz JensSteenmetz enabled auto-merge March 21, 2024 11:39
JoenvandeVorle
JoenvandeVorle previously approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@JoenvandeVorle JoenvandeVorle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awimo

@JensSteenmetz JensSteenmetz disabled auto-merge March 25, 2024 16:05
@JensSteenmetz JensSteenmetz enabled auto-merge (squash) March 25, 2024 16:05
auto-merge was automatically disabled March 25, 2024 18:37

Pull request was closed

@joachimdekker joachimdekker reopened this Mar 25, 2024
@joachimdekker joachimdekker marked this pull request as draft March 25, 2024 21:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JensSteenmetz JensSteenmetz marked this pull request as ready for review March 25, 2024 22:10
SilasPeters
SilasPeters approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GliMaMoVrijMiSpeBiBiBaBoO'Do

@JensSteenmetz JensSteenmetz enabled auto-merge (squash) March 26, 2024 09:53
JoenvandeVorle
JoenvandeVorle approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@JoenvandeVorle JoenvandeVorle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oaiaw (once again it appears well)

@JensSteenmetz JensSteenmetz merged commit b2d544c into main Mar 26, 2024
2 checks passed
@JensSteenmetz JensSteenmetz deleted the feat/100-beliefset-necessities branch March 26, 2024 10:50
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@JensSteenmetz JensSteenmetz restored the feat/100-beliefset-necessities branch March 28, 2024 14:46
@JensSteenmetz JensSteenmetz deleted the feat/100-beliefset-necessities branch June 6, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoenvandeVorle JoenvandeVorle JoenvandeVorle approved these changes

@QuakeEye QuakeEye QuakeEye approved these changes

@SilasPeters SilasPeters SilasPeters approved these changes

@joachimdekker joachimdekker Awaiting requested review from joachimdekker

Assignees

@JensSteenmetz JensSteenmetz

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JensSteenmetz @joachimdekker @SilasPeters @QuakeEye @JoenvandeVorle