Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Tactic structure #18

Merged
merged 10 commits into from
Mar 18, 2024
Merged

Conversation

Tboefijn
Copy link
Contributor

No description provided.

@Tboefijn Tboefijn enabled auto-merge (squash) March 17, 2024 22:16
@JensSteenmetz JensSteenmetz changed the title feature: update tactic structure feature: update Tactic structure Mar 17, 2024
@JensSteenmetz JensSteenmetz changed the title feature: update Tactic structure feature: update Tactic Mar 17, 2024
@QuakeEye QuakeEye changed the title feature: update Tactic feat: update Tactic Mar 17, 2024
@Tboefijn Tboefijn changed the title feat: update Tactic feat: update Tactic structure Mar 17, 2024
@Tboefijn Tboefijn disabled auto-merge March 17, 2024 22:38
@Tboefijn Tboefijn enabled auto-merge (squash) March 17, 2024 22:38
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! I have some small remarks.

Aplib.Core/Tactics/FirstOfTactic.cs Outdated Show resolved Hide resolved
Aplib.Core/Tactics/FirstOfTactic.cs Outdated Show resolved Hide resolved
Aplib.Core/Tactics/AnyOfTactic.cs Show resolved Hide resolved
Aplib.Core/ThreadSafeRandom.cs Outdated Show resolved Hide resolved
Aplib.Core/Tactics/AnyOfTactic.cs Show resolved Hide resolved
joachimdekker
joachimdekker previously approved these changes Mar 18, 2024
Copy link
Contributor

@joachimdekker joachimdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tboefijn Tboefijn disabled auto-merge March 18, 2024 19:01
@Tboefijn Tboefijn enabled auto-merge (squash) March 18, 2024 19:02
joachimdekker
joachimdekker previously approved these changes Mar 18, 2024
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@Tboefijn Tboefijn disabled auto-merge March 18, 2024 20:04
@Tboefijn Tboefijn enabled auto-merge (squash) March 18, 2024 20:04
@Tboefijn Tboefijn requested a review from joachimdekker March 18, 2024 20:04
@Tboefijn Tboefijn merged commit 826ae60 into main Mar 18, 2024
2 checks passed
@Tboefijn Tboefijn deleted the feature/98-update-tactic-structure branch March 18, 2024 20:31
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants