Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add goal instruction #92

Merged
merged 31 commits into from
Jun 19, 2024
Merged

feat: add goal instruction #92

merged 31 commits into from
Jun 19, 2024

Conversation

SSelinn
Copy link
Collaborator

@SSelinn SSelinn commented Jun 10, 2024

Description

Added start room models containing the mural plate. Also added test.

Note: updated all scripts to accommodate the new features of main.

Testability

Start in LevelGeneration and press play. Look around in the first room you spawn in. There you should find the mural.

Checklist

  • Set the proper pull request name
  • Merged main into your branch
  • Added a scene to the game for your changes

@SSelinn SSelinn requested a review from Tboefijn June 10, 2024 09:04
Copy link
Contributor

@Tboefijn Tboefijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some suggestions.

aplib.net-demo/Assets/Art/Materials/MuralJ.mat Outdated Show resolved Hide resolved
aplib.net-demo/Assets/Scripts/WFC/GridPlacer.cs Outdated Show resolved Hide resolved
aplib.net-demo/Assets/Scripts/WFC/GridPlacer.cs Outdated Show resolved Hide resolved
aplib.net-demo/Assets/Scripts/WFC/GridPlacer.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@Tboefijn Tboefijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You forgot to adjust your test.

Co-authored-by: Thijs Boerefijn <[email protected]>
Tboefijn
Tboefijn previously approved these changes Jun 10, 2024
Copy link
Contributor

@Tboefijn Tboefijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SSelinn SSelinn requested a review from joachimdekker June 10, 2024 12:21
Copy link
Contributor

@joachimdekker joachimdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the appended comment.

aplib.net-demo/Assets/Scripts/WFC/GameObjectPlacer.cs Outdated Show resolved Hide resolved
@SSelinn SSelinn marked this pull request as draft June 10, 2024 17:11
@SSelinn SSelinn marked this pull request as ready for review June 12, 2024 10:41
Copy link
Contributor

@joachimdekker joachimdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left one nitpick comment.

aplib.net-demo/Assets/Scripts/WFC/GridPlacer.cs Outdated Show resolved Hide resolved
@SSelinn SSelinn requested a review from joachimdekker June 12, 2024 11:35
Tboefijn
Tboefijn previously approved these changes Jun 12, 2024
Copy link
Contributor

@Tboefijn Tboefijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@joachimdekker joachimdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Tboefijn Tboefijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@Tboefijn Tboefijn merged commit 99a1d8b into main Jun 19, 2024
3 checks passed
@Tboefijn Tboefijn deleted the feat/140-add-goal-instruction branch June 19, 2024 07:32
Copy link

🎉 This PR is included in version 3.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants