test: fix connected components test #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilasPeters
requested changes
Jun 25, 2024
There was a problem hiding this comment.
I love that you used an interface here! You could perhaps even rewrite the complex ablit test (which also doesn't use query actions...)
Speaking of: could you perhaps use a query action to only walk towards the next key if that one exists? Might prevent the edge case I mentioned in a comment
aplib.net-demo/Assets/Testing/AplibTests/ConnectedComponentsTests.cs
Outdated
Show resolved
Hide resolved
SilasPeters
approved these changes
Jun 25, 2024
|
|
🎉 This PR is included in version 3.34.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR writes a new connected components test because the old one didn't work anymore.
Testability
Run ConnectedComponentsTest in the Unity Test Runner
Checklist