Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add GamePlayTests #108

Merged
merged 10 commits into from
Jun 24, 2024
Merged

test: add GamePlayTests #108

merged 10 commits into from
Jun 24, 2024

Conversation

SilasPeters
Copy link
Contributor

@SilasPeters SilasPeters commented Jun 23, 2024

Description

The test to test all tests!
What it tests exactly, is expressed in the GamePlayTests.cs file.

In the process of making logic work, many gameobjects have been given a new layer.

Furthermore, this fixes a bug where an enemy can spawn in starting room.

The test is not optimised, some logic has been expressed but is not tested or visible with the current seed of the level, and it is not completely visible when the enemies get killed.
Furthermore, there is a bug in the game where you hit enemies that are not visible or out of range. Please ignore this, for this is out of scope of the game.
Also, yes the healing works but that is not visible in the current seed. That's simply because the agent is too smart. I will try to make him get damage somehow.

Testability

Run the tests. The scene is GamePlayTestScene.

Checklist

  • Set the proper pull request name
  • Merged main into your branch
  • Added a scene to the game for your changes

@SilasPeters SilasPeters self-assigned this Jun 23, 2024
@SilasPeters SilasPeters mentioned this pull request Jun 23, 2024
3 tasks
@SilasPeters SilasPeters marked this pull request as ready for review June 23, 2024 20:09
@JensSteenmetz JensSteenmetz changed the title test: GamePlayTests test: add GamePlayTests Jun 23, 2024
JensSteenmetz
JensSteenmetz previously approved these changes Jun 24, 2024
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@JoenvandeVorle JoenvandeVorle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall! Got a few comments

Copy link
Contributor

@JoenvandeVorle JoenvandeVorle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awimo!

Copy link
Contributor

@QuakeEye QuakeEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link

@SilasPeters SilasPeters merged commit 504d9ba into main Jun 24, 2024
3 checks passed
@SilasPeters SilasPeters deleted the test/complex-aplib-test branch June 24, 2024 11:49
Copy link

🎉 This PR is included in version 3.34.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants