feat: in-game configuration settings #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilasPeters
requested changes
Jun 19, 2024
JoenvandeVorle
previously requested changes
Jun 19, 2024
aplib.net-demo/Assets/Testing/PlaymodeTests/ConfigurationTests.cs
Outdated
Show resolved
Hide resolved
aplib.net-demo/Assets/Testing/PlaymodeTests/ConfigurationTests.cs
Outdated
Show resolved
Hide resolved
Your* |
SilasPeters
previously approved these changes
Jun 21, 2024
Tboefijn
requested review from
JoenvandeVorle
and removed request for
JoenvandeVorle
|
SilasPeters
approved these changes
Jun 23, 2024
Tboefijn
approved these changes
Jun 23, 2024
|
🎉 This PR is included in version 3.34.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added working in game config where you cannot go out of boundries. Also added test to verify it working.
Testability
Start in the Settings scene and press play. Play around with the values. Grid size cant be smaller than 3 or bigger than 100. The max for all other options is gridvolume *0.7 rounded up.
NOTE: items and enemies have their own max count. If you pass that it will take the max allowed number and divide it by 3 or 2 respectively.
NOTE: sorry for the wrong branch name. It served as a backup if I was not able to merge correctly with main due to all the prefab conflicts, but I managed!
Checklist