Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX/#75] 앱 스토어 로그인 오류 해결 #76

Merged
merged 2 commits into from
Jul 25, 2023
Merged

[FIX/#75] 앱 스토어 로그인 오류 해결 #76

merged 2 commits into from
Jul 25, 2023

Conversation

b1urrrr
Copy link
Member

@b1urrrr b1urrrr commented Jul 24, 2023

⛳️ Work Description

  • 버전코드 7 업데이트
  • reformat code
  • strings.xml 뷰 별 정리

📢 To Reviewers

  • 해시 키 등록 이슈였다~
  • 버전 코드 업데이트 하는 김에 정리만 살짝 했습니당
  • 다들 앱잼동안 너무 고생 많았어! 열정적인 팀원들 덕분에 행복하게 좋은 앱 만든 것 같아💛 2차 스프린트도 힘 내서 달려보자!!!

@b1urrrr b1urrrr added HOTFIX 🚑️ issue나 QA에서 문의된 급한 버그 및 오류 해결 PULL REQUEST 🚀 pull reqeust 날리기 채연 🐸 Chaeyeon's Task labels Jul 24, 2023
@b1urrrr b1urrrr self-assigned this Jul 24, 2023
@b1urrrr b1urrrr requested a review from a team as a code owner July 24, 2023 11:36
Marchbreeze
Marchbreeze approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우리 리드 항상 고생 많았구 넘넘 고마워 ~~~~~~~!!~!

kkk5474096
kkk5474096 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@kkk5474096 kkk5474096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와우~~ 이제 제대로된 코드가 뭔지 보여주쟈!!!

minju1459
minju1459 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@minju1459 minju1459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사랑해 안드 옐로 !!💛

@b1urrrr b1urrrr merged commit 185be05 into develop Jul 25, 2023
1 check passed
@b1urrrr b1urrrr deleted the fix/#75-fix-release-login branch July 25, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marchbreeze Marchbreeze Marchbreeze approved these changes

@minju1459 minju1459 minju1459 approved these changes

@kkk5474096 kkk5474096 kkk5474096 approved these changes

Assignees

@b1urrrr b1urrrr

Labels
HOTFIX 🚑️ issue나 QA에서 문의된 급한 버그 및 오류 해결 PULL REQUEST 🚀 pull reqeust 날리기 채연 🐸 Chaeyeon's Task
Projects
YELL:O ANDROID
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] Signin / 릴리즈 버전 로그인 이슈 해결
4 participants
@b1urrrr @kkk5474096 @minju1459 @Marchbreeze