Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Support in Listen decorator #50

Closed
wants to merge 1 commit into from

Conversation

solidhtp
Copy link

@solidhtp solidhtp commented Oct 6, 2021

Fixes #49.

Changed source type in Listen decorator to Source to support filters.

@raschan
Copy link
Collaborator

raschan commented Oct 6, 2021

@solidhtp It seems like the linting plugin for github actions is still having problems with PRs from forks....
We are in the process of migrating away from github actions, hopefully that would solve this problem.

In the meanwhile, if it's all the same to you, I'll check it manually

@raschan
Copy link
Collaborator

raschan commented Oct 6, 2021

@solidhtp could you fix the failing tests?

@raschan
Copy link
Collaborator

raschan commented Oct 6, 2021

Currently the assumption, that the source can only be string, is running a bit deep in the code. There are a few more changes and checks required for it, to definitly work with everything that we depend on.

In the weekend I'll have more time to have a deeper look.

@solidhtp
Copy link
Author

solidhtp commented Oct 7, 2021

Thanks @raschan . This was the only change I did on my local machine to get it working. I don't have deeper understanding of the code and do not know how deep the impact would be. Please have a look. Let me know if I can help in any way.

@raschan raschan closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no support for filters in listener
2 participants