Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amqp-uri): support special chars in username + password (fix #24) #31

Merged
merged 1 commit into from
Jul 24, 2021

Conversation

tahubu
Copy link
Collaborator

@tahubu tahubu commented Jul 24, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #31 (0ca4dee) into master (4163e8d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0ca4dee differs from pull request most recent head 51b40f2. Consider uploading reports for the commit 51b40f2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          384       437   +53     
  Branches        57        62    +5     
=========================================
+ Hits           384       437   +53     
Impacted Files Coverage Δ
src/service/amqp/amqp.service.ts 100.00% <100.00%> (ø)
src/queue.module.ts 100.00% <0.00%> (ø)
src/util/logger/logger.ts 100.00% <0.00%> (ø)
src/explorer/listener.explorer.ts 100.00% <0.00%> (ø)
src/service/queue/queue.service.ts 100.00% <0.00%> (ø)
src/domain/message-control.domain.ts 100.00% <0.00%> (ø)
...til/exceptions/validation-null-object.exception.ts 100.00% <0.00%> (ø)
...rvice/object-validator/object-validator.service.ts 100.00% <0.00%> (ø)
...nest-amqp-invalid-connection-protocol.exception.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e8562...51b40f2. Read the comment docs.

@tahubu tahubu merged commit 59ae5e5 into master Jul 24, 2021
@tahubu tahubu deleted the fix/amqp-connection-uri branch July 24, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication Failed when username or password contain special characters.
1 participant