feat(queue-module): throw error if no way to create provider is supplied

team-supercharge · Aug 24, 2021 · d711d81 · d711d81
1 parent 76b0cb6
commit d711d81
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/queue.module.spec.ts b/src/queue.module.spec.ts
@@ -168,6 +168,17 @@ describe('QueueModule', () => {
 
       expect(amqpService.getModuleOptions()).toEqual({ connectionUri });
     });
+
+    it('should throw error when no provider is added', async () => {
+      try {
+        Test.createTestingModule({
+          imports: [QueueModule.forRootAsync({ imports: [TestQueueConfigModule] })],
+        });
+        expect.assertions(1);
+      } catch (e) {
+        expect(e.message).toBe('Must provide factory, class or existing provider');
+      }
+    });
   });
 
   describe('make to global module', () => {

diff --git a/src/queue.module.ts b/src/queue.module.ts
@@ -76,8 +76,11 @@ export class QueueModule implements OnModuleInit, OnModuleDestroy {
       };
     }
 
-    // `as Type<QueueOptionsFactory>` is a workaround for microsoft/TypeScript#31603
-    const inject = [(options.useClass || options.useExisting) as Type<QueueModuleOptionsFactory>];
+    if (!options.useClass && !options.useExisting) {
+      throw new Error('Must provide factory, class or existing provider');
+    }
+
+    const inject = [options.useClass ?? options.useExisting];
 
     return {
       provide: QUEUE_MODULE_OPTIONS,