Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce more netcdf attributes for reproducibility #509

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Conversation

dionhaefner
Copy link
Collaborator

Fixes #508

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #509 (576e35d) into main (3d41316) will increase coverage by 0.89%.
Report is 4 commits behind head on main.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   83.76%   84.65%   +0.89%     
==========================================
  Files          86       86              
  Lines        7409     7431      +22     
  Branches      954      957       +3     
==========================================
+ Hits         6206     6291      +85     
+ Misses        932      871      -61     
+ Partials      271      269       -2     
Files Changed Coverage Δ
veros/pyom_compat.py 86.57% <ø> (ø)
veros/runtime.py 75.45% <ø> (ø)
veros/settings.py 84.61% <ø> (ø)
veros/setups/global_1deg/global_1deg.py 13.84% <0.00%> (-0.15%) ⬇️
veros/io_tools/netcdf.py 72.95% <75.00%> (+6.58%) ⬆️
veros/cli/veros_run.py 71.64% <100.00%> (+33.76%) ⬆️
veros/setups/acc/acc.py 96.49% <100.00%> (+0.03%) ⬆️
veros/setups/acc_basic/acc_basic.py 99.00% <100.00%> (+<0.01%) ⬆️
veros/setups/global_4deg/global_4deg.py 97.35% <100.00%> (+0.01%) ⬆️
veros/setups/global_flexible/global_flexible.py 90.04% <100.00%> (+0.04%) ⬆️
... and 2 more

... and 8 files with indirect coverage changes

@dionhaefner dionhaefner merged commit 8142b36 into main Aug 18, 2023
17 of 18 checks passed
@dionhaefner dionhaefner deleted the more-ncattrs branch August 18, 2023 11:14
@jklymak
Copy link

jklymak commented Aug 18, 2023

Thanks a lot for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: more metadata in diagnostic outputs?
2 participants