Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[기능] 메인페이지UI 추가 #8

Merged
merged 2 commits into from
Dec 20, 2024
Merged

[기능] 메인페이지UI 추가 #8

merged 2 commits into from
Dec 20, 2024

Conversation

yoouung
Copy link
Member

@yoouung yoouung commented Dec 18, 2024 •
edited
Loading

📝 개요

  • 메인페이지 UI 구현

✨ 변경 사항

  • 코드나 기능의 주요 변경 사항을 설명합니다.

    • ✨ 메인페이지 UI 구현

📸 스크린샷 (옵션)

image

ℹ️ 참고 사항

TODO:

  • 코스 검색 API 연동
  • 서비스 소개 이미지 만들기

@yoouung yoouung requested a review from erica0321 December 18, 2024 09:20
@yoouung yoouung self-assigned this Dec 18, 2024
@yoouung
Copy link
Member Author

yoouung commented Dec 18, 2024

메인페이지 내용이 너무 없어서 뭘 더 채워야할 것 같은데.. 아이디어가 없슴다 ... 흑흑

erica0321
erica0321 requested changes Dec 18, 2024
View reviewed changes
src/app/page.tsx Outdated Show resolved Hide resolved
src/app/_type/courseType.ts Outdated Show resolved Hide resolved
src/app/page.tsx Show resolved Hide resolved
src/app/page.tsx Show resolved Hide resolved
src/app/page.tsx Outdated Show resolved Hide resolved
src/app/regionData.ts Outdated Show resolved Hide resolved
src/app/_type/courseType.ts Outdated Show resolved Hide resolved
src/app/page.tsx Outdated Show resolved Hide resolved
erica0321
erica0321 requested changes Dec 18, 2024
View reviewed changes
src/app/page.tsx Outdated Show resolved Hide resolved
@yoouung
Copy link
Member Author

yoouung commented Dec 19, 2024

수정 사항

  • 서비스 이용약관/개인정보처리방침 빈 페이지 추가, link href 경로 설정
  • types 폴더로 바꾸고 app 밖으로 이동
    • 카테고리 types/Categories.ts 파일에 저장
  • 스타일 수정(rem -> px, 카테고리)

@erica0321 erica0321 self-requested a review December 20, 2024 03:57
erica0321
erica0321 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@erica0321 erica0321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳쟙

@yoouung yoouung merged commit ddc0d6f into team-joytas:main Dec 20, 2024
@yoouung yoouung deleted the jamie/home branch December 20, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erica0321 erica0321 erica0321 approved these changes

Assignees

@yoouung yoouung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoouung @erica0321