-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 좌표타입 geometry으로 변경 및 기반작업 #457
Changes from all commits
ffa55d4
1ec8215
5d69992
3e4d3e1
37dabdd
52cc21e
7266274
fa1820b
47d78f7
90a8543
4c56926
b97c1d1
b6ca049
13bd3b9
e8480d2
efcb945
7590068
c6f2853
88e35a8
a6cc1dc
248d4d1
b2a3df2
505c401
de561e5
f4f55c5
adee23c
e47c450
a23dc5e
2dfa285
2f1e61b
c6bb957
ccc39d1
3867ee2
d2207e1
5fa2731
2d6b0a1
344fc4b
3c718e0
d2465ad
161a2fa
6e7872b
75fb598
d5fe165
30de966
eeabb97
1131de1
8ed1672
e2e38ef
961ea6d
010158e
bbf13c5
bee5b9d
d4c1f44
73084ac
428f374
1d0fc52
07d4d38
9273238
3159da8
aa7cad2
7f16514
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,3 +1,6 @@ | ||||||||||||||||||
const { configs } = require('@typescript-eslint/eslint-plugin'); | ||||||||||||||||||
const typescriptParser = require('@typescript-eslint/parser'); | ||||||||||||||||||
|
||||||||||||||||||
module.exports = [ | ||||||||||||||||||
{ | ||||||||||||||||||
files: ['**/*.ts'], | ||||||||||||||||||
|
@@ -14,16 +17,15 @@ module.exports = [ | |||||||||||||||||
'generate-migration.js', | ||||||||||||||||||
], | ||||||||||||||||||
languageOptions: { | ||||||||||||||||||
parser: '@typescript-eslint/parser', | ||||||||||||||||||
parser: typescriptParser, | ||||||||||||||||||
parserOptions: { | ||||||||||||||||||
project: './tsconfig.json', | ||||||||||||||||||
tsconfigRootDir: __dirname, | ||||||||||||||||||
sourceType: 'module', | ||||||||||||||||||
}, | ||||||||||||||||||
globals: {}, | ||||||||||||||||||
}, | ||||||||||||||||||
Comment on lines
+20
to
26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Consider extracting parser options for better maintainability. While the parser change is good, the configuration could be more maintainable by extracting the TypeScript-specific options. Consider refactoring to: +const tsParserOptions = {
+ project: './tsconfig.json',
+ tsconfigRootDir: __dirname,
+ sourceType: 'module',
+};
languageOptions: {
parser: typescriptParser,
- parserOptions: {
- project: './tsconfig.json',
- tsconfigRootDir: __dirname,
- sourceType: 'module',
- },
+ parserOptions: tsParserOptions,
},
|
||||||||||||||||||
plugins: { | ||||||||||||||||||
'@typescript-eslint': require('@typescript-eslint/eslint-plugin'), | ||||||||||||||||||
'@typescript-eslint': configs.recommended, | ||||||||||||||||||
prettier: require('eslint-plugin-prettier'), | ||||||||||||||||||
}, | ||||||||||||||||||
Comment on lines
+28
to
30
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Consider consistent plugin import pattern. While the TypeScript plugin now uses imported configs, there's an inconsistency in how plugins are configured (imported configs vs. direct requires). Consider applying the same pattern to all plugins: +const prettierPlugin = require('eslint-plugin-prettier');
plugins: {
'@typescript-eslint': configs.recommended,
- prettier: require('eslint-plugin-prettier'),
+ prettier: prettierPlugin,
}, 📝 Committable suggestion
Suggested change
|
||||||||||||||||||
rules: { | ||||||||||||||||||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update PostgreSQL container to include PostGIS extension.
Given the migration to PostGIS for coordinate storage, the PostgreSQL container needs the PostGIS extension. Update the command to use the PostGIS-enabled image:
📝 Committable suggestion