Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dockerfile bestpractice #154

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/api/dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ COPY --from=builder /usr/local/bin /usr/local/bin

COPY . .

RUN groupadd -r all-in-api && useradd --no-log-init -r -g all-in-api all-in-api
USER all-in-api

EXPOSE 8000

CMD ["uvicorn", "src.app:app", "--reload", "--host", "0.0.0.0", "--port", "8000"]
Expand Down
5 changes: 4 additions & 1 deletion packages/discord/dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ COPY --from=builder /usr/local/bin /usr/local/bin

COPY . .

RUN groupadd -r all-in-api && useradd --no-log-init -r -g all-in-api all-in-api
USER all-in-api

EXPOSE 8000

CMD ["sh", "-c", "uvicorn discordAPI:api --reload --host 0.0.0.0 --port 8000 & python discordAPI.py"]
CMD ["sh", "-c", "uvicorn discordAPI:api --reload --host 0.0.0.0 --port 8000 & python discordAPI.py"]
9 changes: 3 additions & 6 deletions packages/slack/dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,9 @@ COPY --from=builder /usr/local/bin /usr/local/bin

COPY . .

EXPOSE 8000
RUN groupadd -r all-in-api && useradd --no-log-init -r -g all-in-api all-in-api
USER all-in-api

# ADD entrypoint.sh /
# RUN chmod +x /entrypoint.sh
EXPOSE 8000

# CMD ["python", "slack_bot.py"]
# CMD ["python", "slack_bot.py", "&", ";" "uvicorn", "slack_bot:app", "--reload", "--host", "0.0.0.0", "--port", "8000"]
CMD ["sh", "-c", "uvicorn slack_bot:api --reload --host 0.0.0.0 --port 8000 & python slack_bot.py"]
# ENTRYPOINT /entrypoint.sh