[FEAT] 곡 검색하기 구현, 보관함-좋아요 뮤멘트 추가사항 #14 #15 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Controller, Service, DTO 구현 - Router 추가
- 좋아요한 유저와 음악의 _id 필드 추가 - DTO에 필요한 필드 추가 -
hujumee
approved these changes
Jul 16, 2022
| @@ -81,7 +81,7 @@ const getMyMumentList = async (userId: string): Promise<UserMumentListResponseDt | |||
|
|
|||
| const getLikeMumentList = async (userId: string): Promise<UserMumentListResponseDto | null> => { | |||
| try { | |||
| const myMumentList = await Like.findOne({ | |||
| const myMumentList: LikeInfo | null = await Like.findOne({ | |||
| return +new Date(a.createdAt) - +new Date(b.createdAt); | ||
| }); | ||
|
|
||
| console.log(myMumentList.mument); |
There was a problem hiding this comment.
console.log 는 테스트 완료 후 삭제하고 push해줍시다!
| @@ -15,4 +15,6 @@ router.get('/:musicId/:userId/order', [ | |||
| query('default').isString().isIn(['Y', 'N']), | |||
| ], MusicController.getMumentList); | |||
|
|
|||
| router.get('/search', MusicController.getMusicListBySearch); | |||
There was a problem hiding this comment.
쿼리 파라미터 유무 검증 한번 해주면 좋을 것 같습니다!
| const musicRegex = regex(keyword); | ||
|
|
||
| const musicList = await Music.find({ | ||
| $or: [ |
| @@ -117,7 +117,7 @@ const getLikeMumentList = async (userId: string): Promise<UserMumentListResponse | |||
| feelingTag: mument.feelingTag, | |||
| content: mument.content, | |||
| isPrivate: mument.isPrivate, | |||
| likeCount: mument.likeCount, | |||
| likeCount: 0, //쓰이지 않음 | |||
There was a problem hiding this comment.
likeCount는 디비 콜렉션 자체에 없지 않나요?
아예 삭제해줘도 될 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💿 DESCRIPTION
곡 검색하기 : 곡 검색창에 입력한 keyword가 곡 제목/아티스트 명에 포함된 음악들의 리스트 가져오기 [FEAT] 곡 검색하기 #15
보관함-좋아요 뮤멘트 [FEAT] 보관함 좋아요한 뮤멘트 리스트 조회, 필터링 #14 :
🎙 RELATED ISSUE
#14 #15
💃 REVIEW POINT