Sync teads #4

Previous oversight.

* added support for consent for Taboola amp-analytics * fixed the consent substitution variable name * fixed the consent substitution name * fixed unit tests

…roject#34105) * Types: fix all type parse errors * self nits * run prettier * fix a new parse error, make low-bar target

* types: shorthand for |null * a few more * fix test

Co-authored-by: Raghu Simha <[email protected]>

@Suppress

* Clean up directory globs * Move src/core srcs+externs to const arrays * Exclude fetch/get-bounding-client-rect for now * Provide extern for promise-pjs polyfill * Fix types and add comments in abort-controller * Fix types and add comments in intersection-observer-stub * Remove @Suppress {checkTypes} from promise * Fix @this type for document.contains() polyfill * Remove unneeded typecast to unknown * Fix types and add comments in resize-observer-stub * Fix types and add comments in custom-elements * Add ! * Fix types in get-bounding-client-rect * Add more ! * Lint fixes * Allow custom-element.externs.js to use window * Revert no-op JSDoc changes * Remove connected callback externs and typecast instead * Clean up typedefs for observer stubs * Fix typo * Dedupe typedef

Following an update to the Brightcove Player's AMP support plugin, this update makes sure autoplay is handled correctly in all cases. - Removes any autoplay query param, including the interim autoplay=false - Distinguishes play messages sent through postmessage which are autoplay requests

…34222) Extract a wrapper to add video action buttons to an AMP Storybook. https://user-images.githubusercontent.com/254946/117086191-c4e6d700-ad00-11eb-95ff-f9e3b51caf2b.png

…ition (ampproject#34087) * Add package.json for all bento components with npm definition * Add newline at end of file * Fix indentation * Newline at end of file * Fix newline * Add recently published timeago, update NPM definitions * Remove package for render, sidebar, twitter which are not published * Update version for amp-timeago package

Rename `postMessage` method names so that they're uniform with `VideoIframe`'s. This simplifies the upcoming Bento implementation.

…#34250)

…t#34235)

…project#34247)

We can more simply allow `extensions/**` files to import specific files from `amp-video/1.0`. It should be ok in any case.

* runtime: allow for iterator polyfill * Empty commit * lint!

* Do not override user given height until message gives one * Support tweetid directly * Support bootstrap directly * Add unit tests * Support momentid directly * Add Storybook samples for additional options * Use Sinon syntax for spying on setter

) The existing file `test-amp-ima-video.js` is a misnomer since it does not actually test the `<amp-ima-video>` element, only what it loads inside the frame. Accordingly, rename `test-amp-ima-video.js` as `test-ima-video-internal.js`. Also remove stubs specific to the AMP runtime, since it doesn't run inside the iframe.

* Remove Error classification * Left over let declaration * Remove jse error field

* Update OWNERS * Update OWNERS

* Simplify enabling npm bundle * %s/const/let/

…#34267)

…#34237) * refactor: move builtin components to their own folders. organization++ * fix imports / and references in md files. * closure glob include

* Fix conflicts. * Advancement, test and comment. * querySelector * Fix conflicts. * Validator, component and template. * Fix merge conflicts. * Remove duplicate code. * Outlink validator rule. * Alphabetize

* Add comprehensive Storybook samples for amp-twitter * Add deleted and invalid tweet-id cases * Name exported functions in PascalCase

…ct#34258) * Update lts-release.md * Update lts-release.md

Disable `require-jsdoc` since it auto-fixes, and we don't need JSDoc in these locations. We preserve the following rules since they ensure correctness, like type-check already does. jsdoc/check-param-names jsdoc/check-tag-names jsdoc/check-types jsdoc/require-param jsdoc/require-param-name jsdoc/require-param-type jsdoc/require-returns jsdoc/require-returns-type

…34269)

* SVG edit * SVG adjustment. * Drop shadows. * Prevent clipping of decenders. Drop shadow.

ampproject#34208) * Split amp-stream-gallery * Rename jss and type files * Review comments * Add package.json file * Fix indentation * Update npm and latest version in config * Update dependency config * Update zindex doc * Update npm definition

…oject#34158) * SSR compatible design for Toolbar * Various code review comments from Caroline * Additional review comments * Review comments * Remove unused import * Add sanitation * Update sanitization method * Update return type for helper function * Remove truthiness checks that are redundant * Add unit tests

* fix types in runtime-test-base

* references to kleur/colors now pass through build-system/common/colors Co-authored-by: Raghu Simha <[email protected]> * update babel.config

…#34290)

* Handle AutoAdvance duration * Update extensions/amp-story/1.0/amp-story-page.js Co-authored-by: Enrique Marroquin <[email protected]> * Update extensions/amp-story/1.0/page-advancement.js Co-authored-by: Enrique Marroquin <[email protected]> Co-authored-by: Gabriel Majoulet <[email protected]> Co-authored-by: Enrique Marroquin <[email protected]>

…ect#34286)

…on attrs (ampproject#34296) * Add Storybooks for mutation * Reload iframe when context (via name) changes * Add unit test * PascalCase * Named vars in test

* 🚮 Remove unused font from examples * Remove CSS uses without <link> * update validator files

…4204) * added animation options * Removed animation from behaviordef * Added newline on player * Added documentation on options * Use next to toggle animation * Use transitionend * Using classes for CSS * Reverted requestAnimationFrame promise * Added tests * Apply suggestions from code review Co-authored-by: Enrique Marroquin <[email protected]> * Use true instead of property Co-authored-by: Enrique Marroquin <[email protected]> Co-authored-by: Enrique Marroquin <[email protected]>

… carousel (ampproject#34292) * init * nit

`<amp-ima-video>` takes children like: ``` <amp-ima-video> <source data-foo="bar" src="src" /> <track src="src" /> </amp-ima-video> ``` These were previously serialized as HTML on `buildCallback` to be pass to the iframe to (unsafely) write onto `innerHTML`: ``` <amp-ima-video data-child-elements='<source data-foo="bar" src="src" /><track src="src" />' ></amp-ima-video> ``` To prepare for a Bento implementation, we serialize into a JSON format that a Preact component can build more simply and safely: ``` [ ["SOURCE", {"data-foo": "bar", "src": "src"}], ["TRACK", {"src": "src"}] ] ``` This change only affects the interface between the `<amp-ima-video>` element and its own proxy `<iframe>`. It does not affect anything author-facing since they will continue to write children `<source>` and `<track>` elements as such.

…roject#34310) * Pass placeholder and fallback to shadow * Add unit test * Type annotation * Remove auto import

Co-authored-by: Raghu Simha <[email protected]>

* 📦 Update dependency esbuild to v0.11.19 * Add workaround for evanw/esbuild#1202 * Hack: leave .mjs as esm * cleanup * experiment with excluding all of node_modules instead of just .mjs files. * update comment * nit:hoist Co-authored-by: Raghu Simha <[email protected]> Co-authored-by: Jake Fried <[email protected]>

…mpproject#34170) * FirstImpression.io: debug parameters also as query search parameters * FirstImpression.io: use pageViewId64, more debug options

…box` (ampproject#34329)

…r open attachment (ampproject#34330) * Split outlink codepaths. * Lint.

* Use null coalesce and deferred * Use for...of instead of forEach * Simplify Deferred class * Tweak Observable to use removeItem, for..of, ?? * Fix typo * %s/break/continue/

…ampproject#34339)

* Add unit tests for amp-facebook-comments * Fix unit tests in 1.0 * Lint

* wnode script * error handle * log * move files * pr comments

* Create OWNERS file for src/preact * Add jridgewell * carolineliu -> caroqliu

…#34341)

Closes ampproject#34260 Adds additional language around using `_top` in swipe up links (opening the link in the parent window for viewers). (Follow up for ampproject#34030)

…#34338)

* Upgrade Preact to 10.4.8 * update preact to latest Co-authored-by: Jake Fried <[email protected]>

…mpproject#34284) * Prefix user/dev assert fns * Update renamed imports * Update imports to drop "pure" * Update src/utils assert imports * Update src/{polyfills,preact,purifier,web-worker} assert imports * Update src/{inabox,amp-story-player} assert imports * Fix merge breakage * Fix merge breakage

…ration tests (ampproject#34346)

* Provide tryCallback helper * Import shared helper where relevant * Remove spread param * Fix missing import * Update src/core/error.js Co-authored-by: Justin Ridgewell <[email protected]> * Update src/core/error.js Co-authored-by: Justin Ridgewell <[email protected]> * Update src/core/error.js Co-authored-by: Justin Ridgewell <[email protected]>

* Un-extern AssertionFunction typedef * Un-extern Timestamp * Move UnlistenDef to function.extern.js * %s/Timestamp/TimestampDef/ for linter * Fix typo * Fix log type decl

* dedupe rethrowAsync * modernize fetch polyfill * modernize custom-elements polyfill * modernize polyfill stubs * modernize object-assign polyfill * update straggler * Fix typo * typecast elements_ * Revert changes to fetch polyfill * Revert changes to fetch object-assign * Clean up stub types by removing nullability * Update polyfill stub tests * Fix test change

* Move time.js types into src/core/types/date * Move finite-state-machine to core/data-structures * Make core/types/string a submodule * Move base64 and bytes tests with core * Move curve.js to core/data-structures * Make src/core/function a submodule * Update dep-check and conformance configs for string.js * Fix legacy tests * Move tests for exponential backoff * Standardize data structures tests * Update test file structure * Make curve map side-effect-free * Use map and isString helpers * Tweak test names * Fix import * Fix types * Update imports of finite-state-machine * Update imports of bytes and base64 * Update imports of curve * Update imports of exponential-backoff * make lerp static * make getPointX/Y static * make solvePositionFromXValue static * make Bezier fully static * Use Bezier not static this * Fix typo * Use static solver in Curves map * Fix type decls * tweak comments * Remove unused import * Fix imports from merge * Move normtimedef to curve

…mpproject#34248) Use static templates and standalone CSS to simplify how we render a modify `<amp-ima-video>`'s internal tree. This change is unrelated to the Bento effort. Communication between iframe and host is intact.

* Add unit tests for amp-facebook-like * Lint

Update Pressboard analytics config and documentation link.

* feat: Custom style * Revert "feat: Custom style" This reverts commit 2e886ec. * feat: Add custom style * test: Change tests * fix: Fix lint issues * feat: Custom style * Revert "feat: Custom style" This reverts commit 2e886ec. * feat: Add custom style * test: Change tests * fix: Fix lint issues * Revert "fix: Fix lint issues" This reverts commit 386df3f. * fix: Fix lint issues

This fixes a cross binary issue with private properties being mangled to, ie., `lc` inside `BaseElement` base class. The issue is that a subclass extending it in another binary (eg, `amp-a4a`) can reuse that mangled name for something entirely different, because Closure isn't aware of what the base class is at that point.

* SwG release 0.1.22.165 * unbreaks amp test

* Add unit tests for amp-facebook-page * Move amp-facebook-page test to correct location

* fix type errors * make suggested changes * Update build-system/test-configs/jscodeshift/index.js Co-authored-by: Raghu Simha <[email protected]> * Update build-system/tasks/serve.js

…ampproject#34371)

ampproject#33844) * remove functionaltestcontroller, rename functional-test-controller file * rename functional-test-types to e2e-types Co-authored-by: Enrique Marroquin <[email protected]>

* added animation options * Removed animation from behaviordef * Added newline on player * Added documentation on options * Use next to toggle animation * Use transitionend * Using classes for CSS * Reverted requestAnimationFrame promise * Added tests * Apply suggestions from code review Co-authored-by: Enrique Marroquin <[email protected]> * Use true instead of property Co-authored-by: Enrique Marroquin <[email protected]> * Removed trailing whitespace * Fixed linting * Wait for transitionend Co-authored-by: Enrique Marroquin <[email protected]>

* added blue triangle AMP integration info * fixed minor nitpicks for AMP integration * added client ID instead of random substring for guid and session id * added new lines at end of file * amp prettify command changes * Revert "amp prettify command changes" This reverts commit 1c489b2. * reverted last changed, only have the needed changes * got rid of not needed extra url params * changed to endpoint from base * remove question mark * made sure web vitals were present, changed format of client id in vendor example * more changes

* Allow Performance WG to manage check-types * Lint fixes

* Make types/object submodule * Update path in presubmit/lint configs * Move json externs * Move json to core * Shift generic helpers from json to object * Fix test files * Fix types excluding json * Fix types in json * Clean up and remove dupe code * Update imports of json * Remove newlines between imports * Fix dep-check-config * Null chaining for [] and () * Typo * Fix callback

…mpproject#34394) * mv src/experiments.js -> src/experiments/index.js * Make src/experiments pass type-checking * Allow use of window in extern files * Remove unused import * Allow AMP_CONFIG in extern * Modernize experiments code * Enable passing type-checking on src/examiner + modernize * Use assert via logger * un-hoist * Clean up extra type annotations * Fix tests passing object instead of array

…mplate (ampproject#34401) * Improve references to the AMP plugin for WordPress * Fix text to fit on one line and apply to FR template Co-authored-by: Raghu Simha <[email protected]>

* Disabled bookend and related tests * Removed checks to bookend * Linted * Made bookend an alias of social-share * Removed bookend test since it's not showing * Removed bookend tests * Fixed linting * Cleanup * Fixed linting again * Removed visual tests * Fixed test

Co-authored-by: Raghu Simha <[email protected]>

…ampproject#34283) * Initial commit for base-carousel conversion * Additional updates * Add npm files * Update z-index doc * Update z-index

* enable src-context type-check target * Fix type errors in src/context * export ContextPropDef * for...of in scan * clean up scheduler types * Update ContextPropDef in subscriber * update types in index * update types in index * update types in contextprops * update types and for...of in node * Drastically narrow types in values * Add DEP template type to contextpropdef * type-narrow subscriber * Clean up scheduler type decl * use templates in scan * Update index prop and setter types * Allow subscriber ID template type * Add deps template arg for contextprops * Add SID for return type * Assert non-null subscriber IDs * Code review tweak * Remove template type from static function * forEach -> for..of * Revert forEach changes to Maps

When autoplaying a video with a preroll ad, the pause button will not work the first time. This is because we haven't tracked the `PlayerState`. This change keeps track of `PlayerState` on ad events, as meant initially.

* Move query string parsing into core * Update dep-check config * Move query string parsing helper tests * Fix typo * Restore deleted forbidden-terms rule * Update single imports of helpers * Update multi-imports of url helpers * Fix straggler imports * Lint fixes

* IsDevelopmentMode * return boolean jsdoc * Use include since we polyfill Co-authored-by: Ryan Cebulko <[email protected]> * Removed useless comment Co-authored-by: Ryan Cebulko <[email protected]>

* Started removing bookend * Finished removing bookend from files * Fixed linting * Updated validation tests * Updated validation tests 2 * Removed bookend strings * Disabled bookend and related tests * Removed checks to bookend * Linted * Made bookend an alias of social-share * Removed bookend test since it's not showing * Removed bookend tests * Fixed linting * Cleanup * Fixed linting again * Removed visual tests * Fixed test * Fixed test * Fixed request service tests * Fixed visual tests * Bring back validation tests for bookend

…atible with protoc v3.16.0. (ampproject#34428) Co-authored-by: Michael Rybak <[email protected]>

* Created e2e test * Added tests * Fixed e2e tests * Removed comment * Removed unused import * Addede e2es * Moved field to html * More work on e2e * Added load unload fixture * Fixed tests * Added more tests and cleaned up hooks * Added multiple sources on first videos to test flexible-bitrate * Changed e2es to work * Removed whitespaces * Adding cache fetch test * Add e2e fixture to disallowlist for validate * fixed host_url in e2e * Updated tests * Changed order of test conditions for consistency * Update extensions/amp-video/0.1/test-e2e/test-amp-video-flexible-bitrate.js * Update extensions/amp-video/0.1/test-e2e/test-amp-video-flexible-bitrate.js Co-authored-by: Gabriel Majoulet <[email protected]>

ampproject#34434)

…-form` (ampproject#33095) * Init * init * handler => service * Tests * ServiceForDoc no promise * Validator, WeakMap of Array, nits * Update build-system/test-configs/forbidden-terms.js Co-authored-by: Alan Orozco <[email protected]> * Update extensions/amp-form/0.1/amp-form.js Co-authored-by: Alan Orozco <[email protected]> * Update extensions/amp-form/0.1/amp-form.js Co-authored-by: Alan Orozco <[email protected]> * Account for amp-selectors (in and out) * fix test * Update build-system/test-configs/forbidden-terms.js Co-authored-by: Raghu Simha <[email protected]> Co-authored-by: Alan Orozco <[email protected]> Co-authored-by: Raghu Simha <[email protected]>

…34455) See https://output.jsbin.com/yuwojok/29/quiet for a working demo of the bug. When we construct a CustomElement in one document, then insert it into another document (as we do with A4A ads), Firefox incorrectly resets the prototype of our CE instance to `HTMLElement.prototype`. Luckily, we can fix this by listening for the `adoptedCallback`, which fires just after Firefox resets the prototype. If we detect a broken prototype chain, we can correct it before any other code can notice. See https://output.jsbin.com/datajos/5/quiet for a demo of the fix.

* Update npm amphtml-validator to v1.0.35 * Update readme

* Move core/error.js -> core/error/index.js * Move user error helpers to error-message-helpers * Move error-message-helpers to error/message-helpers * spread args in log where slicing * Use loglevel enum in msg_ * Add TODO * string.includes Co-authored-by: Justin Ridgewell <[email protected]> * Update src/core/error/message-helpers.js Co-authored-by: Justin Ridgewell <[email protected]>

Where extensions would previously create `<amp-img>` placeholders, now create a plain `<img>` element with `loading="lazy"`

…oject#34457) * remove brotli check as these files do not exist on cdn anymore * prettier

* Allow IMG so long as it contains a loading attribute * Make width and height mandatory * Move method from within AMP.BaseElement to src/core/dom since it must act on native elements and extended AMP elements now * Update validator output * Mid way stopping point on amp-lightbox-gallery cloneLightboxableElement_ * Lightbox gallery now supports image elements * Use Sets instead of objects * PR feedback on name of utility and usage of other utilities * lightbox had a bad reference * Spy on the right thing now * Remove validator changes for a later step * Carriage returns at the end of the out files for the validator * Updated carriage returns at end of files * Update comments * Move auto lightbox to loadPromise * Remove Set in amp-auto-lightbox * Remove set in amp-image-lightbox * Remove logic specific to amp-img for the img path * Additional fixes for Set usage * test for supporting img on amp-image-lightbox * Add tests for propagate attributes helper and fix usage in iframe-video * Additional fixes for propagateAttributes from AMPElements * Bad merge * pass ampdoc in Criteria so its not obtained from an HTMLElement * change order of arguments to reduce test rewriting for Criteria * Fix types in propagate attributes * Prettier formatting * different prettier versions * update core utility with improved typing from below * Address part of Alans feedback * types * remove toLowerCase on tagName * Test changes from PR feedback (and applied elsewhere in the file) * Add support for native HTMLImageElements to amp-image-slider * Add test using HTMLImageElements * Revert changes to gestures for a later PR * Continued progress, pan zoom works and lightbox gallery is underway * LayoutScheduled for amp-carousel 0.1 when unlayout happening * Remove image support for amp-image-viewer for a future PR * Image Viewer no longer needs to exclude itself from using loadPromise directly * Remove console logging for carousel debugging: * Remove breaks in parsing of children for amp-image-slider * No need to provide an empty array for the Set constructor * Remaining console * Nit * Remove more intermediary state changes * Naming nit * prettier formatting in test

…#34463)

* Revert "Revert "amp-list: Fix Bind.rescan vs. diffing race condition (ampproject#32650)" (ampproject#33232)" This reverts commit 60adca7. * Support diffable with single-item. * Fix test. * Fix lint.

…#34476)

…rs and transport (ampproject#34423) * added blue triangle AMP integration info * fixed minor nitpicks for AMP integration * added client ID instead of random substring for guid and session id * added new lines at end of file * amp prettify command changes * Revert "amp prettify command changes" This reverts commit 1c489b2. * reverted last changed, only have the needed changes * got rid of not needed extra url params * changed to endpoint from base * remove question mark * made sure web vitals were present, changed format of client id in vendor example * more changes * changed blue triangle trigger to ini-load, added test variable to vendors example page, changed blue triangle transport to xhrpost

…mpproject#34478)

… and animation (ampproject#34477) * Remove open attachment delay. * Revise preview animation duration.

…mpproject#34482) * Prevent `[width][height][sizes]` selectors from inadvertently matching `img` elements * Allow `height` and `width` on `amp-img > img (transformed)`

…34425)

…project#34223) * visual tests * make pages look same * nit * revert nit * remove references to inline-dark-theme visual test * adding images and extra tests * moving tests for v2 to a diff file * documenting v2 tests * adding cover id * adding snapshots and experiment * change IDs * adding js test navigation * adding js test navigation * formatting * edit tests * format * format * format * adding next page * adding next page * adding rest of pages * lint * testing adding active on openAttachmentEl * changing selector * typo * adding important * Improve targeting of img in remote-content. * Refactor go to page Removes tap simulation to navigate to page. Removes timeout. Improves selector to be sure page is visible. * Use same interactive tests for desktop. * Remove desktop.js JS can be re-used for desktop and mobile. Co-authored-by: Philip Bell <[email protected]>

* Use WebAssembly validator for chrome extension * Use es5 for popup.html * Init wasm before polymer code

…ect#34509)

* Use isModeDevelopment * fix test failures * update related test

* patched all fixable type errors Co-authored-by: Raghu Simha <[email protected]>

…#34524)

Added data-jsontargeting and data-extras attributes to adpushup amp-ad vendor integration Co-authored-by: Rahul Ranjan <[email protected]>

…4525)

…d URLs (ampproject#34510)

…ect#34528) * Updates for react npm * Ignore eslint rule

* Don't populate spec_file_revision field in ValidationResult. The field is deprecated. PiperOrigin-RevId: 373462878 * Delete ParsedValidatorRules::SpecFileRevision(). PiperOrigin-RevId: 373688076 * Allow i-amphtml-layout-awaiting-size class in FLUID layout PiperOrigin-RevId: 375586004 Co-authored-by: Googler <[email protected]> Co-authored-by: Justin Ridgewell <[email protected]>

…ut (ampproject#34533) Co-authored-by: Justin Ridgewell <[email protected]>

* Fix out of memory errors for a particular fuzzer test case which end up in parsing entire contents of a binary blob as attributes. Defined a flag for maximum attributes a node may contain. This value is reasonably large to cover all real world documents. PiperOrigin-RevId: 375586875 * Update CONTRIBUTING.md * Update README.md * Update amp4ads-parse-css.h * Add missing dependency Co-authored-by: Amaltas Bohra <[email protected]>

…ampproject#34535) * Element child * Revert regression * Trigger click from light dom * Revert. * revert * revert * Revert

…34558) Co-authored-by: honeybadgerdontcare <[email protected]>

…ject#34550) * Move utils/dom-fingerprint to core/dom/fingerprint * Fix imports in fingerprint.js * Move utils/date to core/dom/parse-date-attributes * Improve types in parse-date-attributes * Move utils/dom-based-weakref to core/dom/weakref * Update test names * Add __AMP_WEAKREF_ID extern * Move math, id-gen, layout-rect to core/math * Update types for layout-rect * Move get-html into core/dom * Move isFiniteNumber into core/types * Move document-ready to core * Move web-components to core/dom * Fix types in web-components * Move dom streaming helpers to core/dom/stream * Update imports of dom-fingerprint * Update imports of parseDateAttrs * Update (only) import of DomBasedWeakRef * Update imports of math helpers * Update imports of get-html * Update imports of isFiniteNumber * Update imports of document-ready * Update imports of web-components * Update imports of dom stream helpers * Update forbidden-terms * Not nullable type

* Add SSR support for FLUID layout PiperOrigin-RevId: 375756231 * Extract AMP Cache Domain validation, part 1 Adds method isAmpCacheDomain_ (JS) / IsAmpCacheDomain (C++) PiperOrigin-RevId: 375855105 Co-authored-by: Justin Ridgewell <[email protected]> Co-authored-by: honeybadgerdontcare <[email protected]>

* add check-build-system to pr checks * fix more type errors * disable incremental builds Co-authored-by: Raghu Simha <[email protected]>

…4548)

* Update file naming from mjs to module * import exports should be in alphabetical order * Rename helper function

…gName` (ampproject#34312) * Switch based on data-embed-as versus tag name * Update tests * Update FacebookComments * Allow dependency on enum * Remove staticProps * Update all the tests * Remove dupe * Import userAssert * Allow dependency on enum

…roject#34359) * ✨ Supports locale options for localeString in amp-date-display. * Allow user to customize locale options for localeString, the options setting is same as [Date.toLocaleString](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleString#syntax) parameter. * [amp-date-display] Moves localeOptions from json type to data-options-*. * [amp-date-display] Tests and content imporvements. - Added invalid test cases. - Throws user error if invalid data-options-* param is provided. - Updated data-options-* readme doc. - Added new lines to .out validator files. - Applied reviewer suggestions.

…ease tracker (ampproject#34575)

…he next (ampproject#34569) Co-authored-by: Raghu Simha <[email protected]>

* Remove the need to explicitly specify extern globs * Add clarifying comment * Allow type-check target to just be a list of globs * Update type * More explanatory comments * More comments

* Video cache for amp-video[src]. * Update extensions/amp-video/0.1/video-cache.js Co-authored-by: Justin Ridgewell <[email protected]> * Update extensions/amp-video/0.1/video-cache.js * Import iterateCursor. * Reviews. Co-authored-by: Justin Ridgewell <[email protected]>

* allowing add data-attributes * using dataset for shorter code * fixing error use of style to style elements is forbidden * fixing default attribute values * removing sizes * allowing use min height * fixing banner alignment * fixing test * fixing prettier validation * fixing prettier validation

…hing (ampproject#34586) * update node script * lint * pr comments * lint

This reverts commit 5a0936f.

…pproject#34591)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync teads #4

Sync teads #4

Commits on Jun 1, 2021