Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_CLASS_FOUND #77

Open
iDigBioBot opened this issue Jan 5, 2018 · 7 comments
Open

TG2-VALIDATION_CLASS_FOUND #77

iDigBioBot opened this issue Jan 5, 2018 · 7 comments
Labels
Conformance CORE TG2 CORE tests NAME Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation VOCABULARY

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID 2cd6884e-3d14-4476-94f7-1191cfff309b
Label VALIDATION_CLASS_FOUND
Description Does the value of dwc:class occur at rank of Class in bdq:sourceAuthority?
TestType Validation
Darwin Core Class dwc:Taxon
Information Elements ActedUpon dwc:class
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:class is bdq:Empty; COMPLIANT if the value of dwc:class is found as a value at the rank of Class in the bdq:sourceAuthority; otherwise NOT_COMPLIANT
Data Quality Dimension Conformance
Term-Actions CLASS_FOUND
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]}
Specification Last Updated 2023-09-18
Examples [dwc:class="Insecta": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:class has an equivalent at the rank of Class in the bdq:sourceAuthority"]
[dwc:class="Magnoleopsida": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:class does not have an equivalent at the rank of Class in the bdq:sourceAuthority"]
Source
References
Example Implementations (Mechanisms) Kurator/FilteredPush sci_name_qc Library
Link to Specification Source Code https://github.com/FilteredPush/sci_name_qc/blob/v1.1.2/src/main/java/org/filteredpush/qc/sciname/DwCSciNameDQ.java#L1349
Notes The purpose of this test is to check whether the value is a name that is a result of a nomenclatural act at this rank. This excludes unpublished names, misspellings and vernacular names. It is expected that the test will designate the source authority against to check. The same test might return distinct results when using distinct source authorities.
@pzermoglio pzermoglio changed the title TG2-VALIDATION_CLASS_NOTSTANDARD TG2-VALIDATION_CLASS_NOTFOUND Jan 18, 2018
@ArthurChapman ArthurChapman added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Jan 18, 2018
@tucotuco tucotuco added the Parameterized Test requires a parameter label Nov 5, 2018
chicoreus added a commit that referenced this issue Oct 5, 2020
…railing whitespace, removing default parameter values that don't actually reference the default service, enclosing strings in quotes. Adding a test case with the information element name as the value.
@Tasilee Tasilee changed the title TG2-VALIDATION_CLASS_NOTFOUND TG2-VALIDATION_CLASS_FOUND Mar 22, 2022
@Tasilee
Copy link
Collaborator

Tasilee commented Apr 22, 2022

I have updated the specs for this test (Source Authority) by taking the ref in the Notes (updated by References) to the Source Authority.

To me, this conflicts with for example #187 in that we provide values for bdq terms in the Parameters vs Source Authority.

We also now often have three refs to bdq:sourceAuthority (Parameters, Source Authority and References) which strikes me as a tad redundant.

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 22, 2022

@chicoreus has now amended the Parameters and Source Authority as if all agree, we will use this format as a template for similar tests.

Parameters should follow the same format as Information Elements if there is more than one (1/line)

@Tasilee
Copy link
Collaborator

Tasilee commented Jun 19, 2022

I changed the Example

dwc:class="Herps"

to

dwc:class="Mammalia"

to better align with the reflection of "NOT_FOUND" to "FOUND". This may likely apply to other Examples (which I will check).

@Tasilee
Copy link
Collaborator

Tasilee commented Jan 30, 2023

I've changed Example 2 to align with test data.

@Tasilee
Copy link
Collaborator

Tasilee commented Jun 13, 2023

Restructured Parameter(s) and Source authority

chicoreus added a commit to FilteredPush/sci_name_qc that referenced this issue Jun 26, 2023
…tdwg/bdq specifications. Updated metadata (added ProvidesVersion and Specification) for tdwg/bdq#77 tdwg/bdq#83 tdwg/bdq#28 tdwg/bdq#122. VALIDATIONs for CLASS, ORDER, FAMILY, GENUS NOTEMPTY.  Updated metadata, no changes to specifications. removing reviewed stub methods.
chicoreus added a commit to FilteredPush/sci_name_qc that referenced this issue Jun 26, 2023
…tdwg/bdq specifications. Updated metadata (added ProvidesVersion and Specification) for tdwg/bdq#77 tdwg/bdq#83 tdwg/bdq#28 tdwg/bdq#101 VALIDATION_POLYNOMIAL_CONSISTENT.  Updated metadata. removing reviewed stub method. Added test cases to conirm expected NOT_EMPTY comparison behavior.
@Tasilee
Copy link
Collaborator

Tasilee commented Jul 4, 2023

Amended Source Authority values to align with @chicoreus syntax

From

bdq:sourceAuthority default = "GBIF Backbone Taxonomy" [https://doi.org/10.15468/39omei] |
| | API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]

to

bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]}

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 18, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted".

Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated"

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conformance CORE TG2 CORE tests NAME Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation VOCABULARY
Projects
None yet
Development

No branches or pull requests

5 participants