Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-AMENDMENT_OCCURRENCESTATUS_ASSUMEDDEFAULT #75

Open
iDigBioBot opened this issue Jan 5, 2018 · 44 comments
Open

TG2-AMENDMENT_OCCURRENCESTATUS_ASSUMEDDEFAULT #75

iDigBioBot opened this issue Jan 5, 2018 · 44 comments
Labels
Amendment Completeness CORE TG2 CORE tests OTHER Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 VOCABULARY

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID 96667a0a-ae59-446a-bbb0-b7f2b0ca6cf5
Label AMENDMENT_OCCURRENCESTATUS_ASSUMEDDEFAULT
Description Proposes an amendment of the value of dwc:occurrenceStatus to the default parameter value if dwc:occurrenceStatus, dwc:individualCount and dwc:organismQuantity are empty.
TestType Amendment
Darwin Core Class dwc:Occurrence
Information Elements ActedUpon dwc:occurrenceStatus
Information Elements Consulted dwc:individualCount
dwc:organismQuantity
Expected Response INTERNAL_PREREQUISITES_NOT_MET if dwc:occurrenceStatus is bdq:NotEmpty; FILLED_IN the value of dwc:occurrenceStatus using the bdq:defaultOccurrenceStatus Parameter value if dwc:occurrenceStatus, dwc:individualCount and dwc:organismQuantity are bdq:Empty; otherwise NOT_AMENDED
Data Quality Dimension Completeness
Term-Actions OCCURRENCESTATUS_ASSUMEDDEFAULT
Parameter(s) bdq:defaultOccurrenceStatus
Source Authority bdq:defaultOccurrenceStatus default = "present"
Specification Last Updated 2024-11-13
Examples [dwc:occurrenceStatus="", dwc:individualCount="", dwc:organismQuantity="": Response.status=FILLED_IN, Response.result=dwc:occurrenceStatus="present", Response.comment="dwc:occurrenceStatus is bdq:Empty; assumed "Present""]
[dwc:occurrenceStatus="X", dwc:individualCount="10", dwc:organismQuantity="": Response.status=NOT_AMENDED, Response.result="", Response.comment="dwc:occurrenceStatus is bdq:NotEmpty"]
Source ALA
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes There is currently a mismatch between https://dwc.tdwg.org/terms/#dwc:occurrenceStatus recommended values and the vocabulary at bdq:sourceAuthority that we are using (https://api.gbif.org/v1/vocabularies/OccurrenceStatus/concepts)
@iDigBioBot
Copy link
Collaborator Author

Comment by Paul Morris (@chicoreus) migrated from spreadsheet:
Widespread assumption in vouchered occurrence data. Likely to be important when aggregating with any data with 'absent' values. However, this is an amendment: a value of "present" is being provided for dwc:occurrenceStatus when dwc:occurrenceStatus is either empty or not present.

@ArthurChapman ArthurChapman added VOCABULARY Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT OTHER and removed SPACE labels Jan 17, 2018
@ArthurChapman
Copy link
Collaborator

ArthurChapman commented Jan 30, 2018

Why could this not be incorporated under #115 AMENDMENT_OCCURRENCESTATUS_STANDARDIZED?

@Tasilee
Copy link
Collaborator

Tasilee commented Jan 30, 2018

That I would tend to agree with as we could easily add this special case. Comments from others?

@Tasilee Tasilee changed the title TG2-AMENDMENT_OCCURRENCESTATUS_ASSUMEDPRESENT TG2-NOTIFICATION_OCCURRENCESTATUS_ASSUMEDPRESENT Aug 14, 2018
@Tasilee Tasilee changed the title TG2-NOTIFICATION_OCCURRENCESTATUS_ASSUMEDPRESENT TG2-AMENDMENT_OCCURRENCESTATUS_ASSUMEDPRESENT Aug 14, 2018
@Tasilee
Copy link
Collaborator

Tasilee commented Aug 14, 2018

In retrospect, if we are going to effectively treat EMPTY or an uninterpretable value as "present" then it is indeed an amendment. Sigh.

@tucotuco
Copy link
Member

Agreed at TDWG 2018 DQIG meeting that this amendment can only be applied if the the value of dwc:occurrenceStatus is empty.

@ArthurChapman
Copy link
Collaborator

I wonder if we should change the name of this test to AMENDMENT_OCCURRENCESTATUS_ASSUMEDDEFAULT to parallel #102. Any comments? I realise the default has only the one possible value - i.e. "Present" but I am attempting to reduce the things we have to define.

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 7, 2018

After reviewing all, I'd agree. Changed accordingly

@Tasilee Tasilee changed the title TG2-AMENDMENT_OCCURRENCESTATUS_ASSUMEDPRESENT TG2-AMENDMENT_OCCURRENCESTATUS_ASSUMEDDEFAULT Sep 7, 2018
@chicoreus
Copy link
Collaborator

Inconsistency snuck in somewhere in the editing history, this is now clearly labeled as an amendment, but retains an output type of Notification, changing this to Amendment for consistency.

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 18, 2022

Changed "AMENDED" to "FILLED_IN" in accordance with discussions April 16. I also moved the INTERNAL_PREREQUISITES_NOT_MET test into the FILLED_IN part as this aligns with similar amendments.

@Tasilee
Copy link
Collaborator

Tasilee commented Jan 30, 2023

Edited Example 2 as there is no "INTERNAL_PREREQUISITES_NOT_MET". There was an error in the test data, now fixed.

[dwc:occurrenceStatus="X": Response.status=NOT_AMENDED, Response.result="", Response.comment="dwc:occurrenceStatus is not EMPTY"]

@ymgan
Copy link
Collaborator

ymgan commented Feb 19, 2023

Hey, out of curiousity, may I know why the amendment of occurrenceStatus (to default = "present") does not consider the value of individualCount or organismQuantity and organismQuantityType?

I am thinking that it is possible to have situation where occurrenceStatus is empty but individualCount is >0 individualCount = 0. Please see:

Thank you!!

Edit: sorry, I noticed that I made a mistake in this comment

@ArthurChapman ArthurChapman added the Parameterized Test requires a parameter label Mar 24, 2023
@ymgan
Copy link
Collaborator

ymgan commented Mar 24, 2023

Agreed - this simplifies it. @ymgan does this satisfy your issues?

Yes, thank you very much for your hard work here! I really appreciate it!

@Tasilee
Copy link
Collaborator

Tasilee commented Mar 26, 2023

I have updated the Description and the Examples accordingly and will amend the test data.

@Tasilee
Copy link
Collaborator

Tasilee commented Mar 27, 2023

I have added dwc:individualCount and dwc:organismQuantity to the Information Elements.

@Tasilee
Copy link
Collaborator

Tasilee commented Jun 13, 2023

Restructured Parameter(s) and Source authority

@ArthurChapman
Copy link
Collaborator

Change sourceAuthority from "dwc:occurrenceStatus = "present"" to "dwc:occurrenceStatus default = "present""

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 18, 2023

Changed all Information Elements to "ActedUpon" as per Paul's Java Code.

@chicoreus: You will need to amend your code to include dwc:individualCount and dwc:organismQuantity ?

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
@chicoreus
Copy link
Collaborator

The parameter can't be the same as an information element.

Propose changing the parameter from dwc:occurrenceStatus to bdq:defaultOccurrenceStatus

chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Jul 27, 2024
…o evaluate LSIDs and UUIDs, lookups from GBIF vocabulary for several terms and storage for access in a singleton. Completed all but one stub unit test, commented that one for build. Implementations include tdwg/bdq#75 tdwg/bdq#115 tdwg/bdq#277 tdwg/bdq#285.
chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Jul 28, 2024
@Tasilee
Copy link
Collaborator

Tasilee commented Jul 29, 2024

Thanks @chicoreus - that seems a reasonable solution to me. Amending.

@Tasilee
Copy link
Collaborator

Tasilee commented Aug 18, 2024

Changed Expected Response from

FILLED_IN the value of dwc:occurrenceStatus using the Parameter value if dwc:occurrence.Status, dwc:individualCount and dwc:organismQuantity are EMPTY; otherwise NOT_AMENDED

to

FILLED_IN the value of dwc:occurrenceStatus using the Parameter value if dwc:occurrenceStatus, dwc:individualCount and dwc:organismQuantity are EMPTY; otherwise NOT_AMENDED

@ymgan
Copy link
Collaborator

ymgan commented Aug 19, 2024

May I know if we need a VALIDATION_ORGANISMQUANTITY_NOTEMPTY please? We already have

@ArthurChapman
Copy link
Collaborator

Thanks @ymgan - #232 is Supplementary at this stage and another test for VALIDATION_ORGANISMQUANTITY_NOTEMPTY could be valuable for some, but at this stage we don't think it is widely applicable. But it is certainly one worth considering in the future if required. There are quite a few tests in a similar position that we don't believe are CORE.

@ymgan
Copy link
Collaborator

ymgan commented Aug 19, 2024

Thanks @ArthurChapman !! Good morning :D To make sure that I understand, even if this test is core and its prerequisite include individualCount and organismQuantity are empty, it does not mean we need the notempty tests for individualCount and organismQuantity. Am I correct?

@chicoreus
Copy link
Collaborator

chicoreus commented Aug 19, 2024 via email

@ymgan
Copy link
Collaborator

ymgan commented Aug 19, 2024

got it, thanks @chicoreus !

@chicoreus
Copy link
Collaborator

This and #102 are "AssumedDefault" tests for which non-empty values aren't preventing execution of the test, that should probably both have the internal prerequisites clause removed and be able to reach the NOT_AMENDED clause:

FILLED_IN the value of dwc:occurrenceStatus using the Parameter value if dwc:occurrenceStatus, dwc:individualCount and dwc:organismQuantity are bdq:Empty; otherwise NOT_AMENDED

@Tasilee
Copy link
Collaborator

Tasilee commented Nov 11, 2024

I agree with removing the INTERNAL_PREREQUISITES_NOT_MET phrase on this Test.

@Tasilee
Copy link
Collaborator

Tasilee commented Nov 12, 2024

Do we change default to "Present" for now as "present" won't currently validate against the GBIF vocabulary?

@chicoreus
Copy link
Collaborator

chicoreus commented Nov 12, 2024 via email

@Tasilee
Copy link
Collaborator

Tasilee commented Nov 12, 2024

Added to Notes " There is currently a mismatch between https://dwc.tdwg.org/terms/#dwc:occurrenceStatus recommended values and the vocabulary at bdq:sourceAuthority that we are using (https://api.gbif.org/v1/vocabularies/OccurrenceStatus/concepts)"

@chicoreus
Copy link
Collaborator

Corrected the parameter namespace for bdq:defaultOccurrenceStatus from dwc to bdq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Amendment Completeness CORE TG2 CORE tests OTHER Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 VOCABULARY
Projects
None yet
Development

No branches or pull requests

6 participants