-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-AMENDMENT_OCCURRENCESTATUS_ASSUMEDDEFAULT #75
Comments
Comment by Paul Morris (@chicoreus) migrated from spreadsheet: |
Why could this not be incorporated under #115 AMENDMENT_OCCURRENCESTATUS_STANDARDIZED? |
That I would tend to agree with as we could easily add this special case. Comments from others? |
In retrospect, if we are going to effectively treat EMPTY or an uninterpretable value as "present" then it is indeed an amendment. Sigh. |
Agreed at TDWG 2018 DQIG meeting that this amendment can only be applied if the the value of dwc:occurrenceStatus is empty. |
I wonder if we should change the name of this test to AMENDMENT_OCCURRENCESTATUS_ASSUMEDDEFAULT to parallel #102. Any comments? I realise the default has only the one possible value - i.e. "Present" but I am attempting to reduce the things we have to define. |
After reviewing all, I'd agree. Changed accordingly |
Inconsistency snuck in somewhere in the editing history, this is now clearly labeled as an amendment, but retains an output type of Notification, changing this to Amendment for consistency. |
Changed "AMENDED" to "FILLED_IN" in accordance with discussions April 16. I also moved the INTERNAL_PREREQUISITES_NOT_MET test into the FILLED_IN part as this aligns with similar amendments. |
Edited Example 2 as there is no "INTERNAL_PREREQUISITES_NOT_MET". There was an error in the test data, now fixed. [dwc:occurrenceStatus="X": Response.status=NOT_AMENDED, Response.result="", Response.comment="dwc:occurrenceStatus is not EMPTY"] |
Hey, out of curiousity, may I know why the amendment of occurrenceStatus (to default = "present") does not consider the value of individualCount or organismQuantity and organismQuantityType? I am thinking that it is possible to have situation where occurrenceStatus is empty but Thank you!! Edit: sorry, I noticed that I made a mistake in this comment |
Yes, thank you very much for your hard work here! I really appreciate it! |
I have updated the Description and the Examples accordingly and will amend the test data. |
I have added dwc:individualCount and dwc:organismQuantity to the Information Elements. |
Restructured Parameter(s) and Source authority |
Change sourceAuthority from "dwc:occurrenceStatus = "present"" to "dwc:occurrenceStatus default = "present"" |
Changed all Information Elements to "ActedUpon" as per Paul's Java Code. @chicoreus: You will need to amend your code to include dwc:individualCount and dwc:organismQuantity ? |
The parameter can't be the same as an information element. Propose changing the parameter from dwc:occurrenceStatus to bdq:defaultOccurrenceStatus |
…o evaluate LSIDs and UUIDs, lookups from GBIF vocabulary for several terms and storage for access in a singleton. Completed all but one stub unit test, commented that one for build. Implementations include tdwg/bdq#75 tdwg/bdq#115 tdwg/bdq#277 tdwg/bdq#285.
…TUS_ASSUMEDDEFAULT.
Thanks @chicoreus - that seems a reasonable solution to me. Amending. |
Changed Expected Response from FILLED_IN the value of dwc:occurrenceStatus using the Parameter value if dwc:occurrence.Status, dwc:individualCount and dwc:organismQuantity are EMPTY; otherwise NOT_AMENDED to FILLED_IN the value of dwc:occurrenceStatus using the Parameter value if dwc:occurrenceStatus, dwc:individualCount and dwc:organismQuantity are EMPTY; otherwise NOT_AMENDED |
May I know if we need a VALIDATION_ORGANISMQUANTITY_NOTEMPTY please? We already have |
Thanks @ymgan - #232 is Supplementary at this stage and another test for VALIDATION_ORGANISMQUANTITY_NOTEMPTY could be valuable for some, but at this stage we don't think it is widely applicable. But it is certainly one worth considering in the future if required. There are quite a few tests in a similar position that we don't believe are CORE. |
Thanks @ArthurChapman !! Good morning :D To make sure that I understand, even if this test is core and its prerequisite include individualCount and organismQuantity are empty, it does not mean we need the notempty tests for individualCount and organismQuantity. Am I correct? |
On Mon, 19 Aug 2024 07:10:09 -0700 Yi-Ming Gan ***@***.***> wrote:
Thanks @ArthurChapman !! Good morning :D To make sure that I
understand, even if this test is core and its prerequisite include
individualCount and organismQuantity are empty, it does not mean we
need the notempty tests for individualCount and organismQuantity. Am
I correct?
Non-empty tests for individualCount and organismQuantity would ba aspirational at this point.
If we adopted them we would be asserting that these terms would be important enough for everyone to try to put in the effort to populate them. For natural science collections data at least, this would be non-trivial, collections may know how many parts they have for some specimen, but not be readily able to work out how many individuals those represent.
So, yes, these do make natural related tests, but not really within the scope of what we want to accomplish. Others, for whom quality in this portion of the data, can easily propose a use case and suite of tests.
|
got it, thanks @chicoreus ! |
This and #102 are "AssumedDefault" tests for which non-empty values aren't preventing execution of the test, that should probably both have the internal prerequisites clause removed and be able to reach the NOT_AMENDED clause: FILLED_IN the value of dwc:occurrenceStatus using the Parameter value if dwc:occurrenceStatus, dwc:individualCount and dwc:organismQuantity are bdq:Empty; otherwise NOT_AMENDED |
I agree with removing the INTERNAL_PREREQUISITES_NOT_MET phrase on this Test. |
Do we change default to "Present" for now as "present" won't currently validate against the GBIF vocabulary? |
On Mon, 11 Nov 2024 18:48:40 -0800 Lee Belbin ***@***.***> wrote:
Do we change default to "Present" for now as "present" won't
currently validate against the GBIF vocabulary?
Yes. Good catch. Probably worth adding a note as well.
|
Added to Notes " There is currently a mismatch between https://dwc.tdwg.org/terms/#dwc:occurrenceStatus recommended values and the vocabulary at bdq:sourceAuthority that we are using (https://api.gbif.org/v1/vocabularies/OccurrenceStatus/concepts)" |
Corrected the parameter namespace for bdq:defaultOccurrenceStatus from dwc to bdq. |
The text was updated successfully, but these errors were encountered: