-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-AMENDMENT_COORDINATES_TRANSPOSED #54
Comments
Comment by Paula Zermoglio (@pzermoglio) migrated from spreadsheet: |
Comment by Paul Morris (@chicoreus) migrated from spreadsheet: |
This one still has problems. I would replace the current Expected Response "INTERNAL_PREREQUISITES_NOT_MET if dwc:decimalLatitude and dwc:decimalLongitude are EMPTY or the values of dwc:decimalLatitude and dwc:decimalLongitude passed to the dwc:countryCode specified source authority service were not in the same spatial reference system as that of the service; AMENDED if the supplied geographic coordinates were transposed or one or more of the signs were reversed (negated) to place the record in the region defined by the supplied dwc:countryCode; otherwise NOT_CHANGED" with "INTERNAL_PREREQUISITES_NOT_MET if any of dwc:decimalLatitude or dwc:decimalLongitude or dwc:countryCode is EMPTY; AMENDED if the supplied geographic coordinates were transposed or one or more of the signs were reversed (negated) to place the record in the region defined by the supplied dwc:countryCode; otherwise NOT_CHANGED" For the Notes, I would add "The dwc:geodeticDatum is not necessary for this test. The maximum positional shift between any geographic coordinate reference system and WGS84 is less than 6 km, so any hemisphere test that relies on a country code for consistency would not be affected by the potential shift." |
We have a quorum, so edited accordingly, with one change "is" to "are". |
Updated Note #50 to VALIDATION_COORDINATE_COUNTRYCODE_CONSISTENT (adb27d29-9f0d-4d52-b760-a77ba57a69c9) |
Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Also changed "Field" to "TestField" and "Output Type" to "TestType". |
Needs a sourceAuthority for spatial data to go with the countryCodes. |
…ssing stub methods and TODOs marking test implementations with metadata not up to date with current specifications. Added implementation of tdwg/bdq#54, ahead of current specification by adding needed source authority parameter.
Source Authority added: bdq:sourceAuthority default = "ISO 3166 Country Codes" {[https://www.iso.org/iso-3166-country-codes.html]} {ISO 3166-1-alpha-2 Country Code search [https://www.iso.org/obp/ui/#search]} |
@Tasilee the sourceAuthority issue hasn't been addressed yet. A spatial source authority is needed. The list of country codes does not provide information to match latitudes/longitudes to country codes. We could use the same one we use in #73 AMENDMENT_COUNTRYCODE_FROM_COORDINATES: bdq:sourceAuthority default = "10m-admin-1 boundaries UNION with Exclusive Economic Zones" |
Indeed. And as we have a bdq:sourceAuthority, we need another bdq: as in bdq:countriesWithBuffers or similar? We then also have that as a Parameter as it could be adapted? This means another vocab term as I can't see any other terms we could meaningfully re-use. I'll amend and await comment... |
@Tasilee we don't need a new term, we just need to replace the existing sourceAuthority (which containing only country codes is not relevant to this issue, where country code matching to spatial data is provided by the natural earth data). We only need a single sourceAuthority: bdq:sourceAuthority default = "10m-admin-1 boundaries UNION with Exclusive Economic Zones" {[https://www.naturalearthdata.com/downloads/10m-cultural-vectors/10m-admin-1-states-provinces/] spatial UNION [https://www.marineregions.org/downloads.php#marbound]} |
OK, done. |
Changing expected response to include the bdq:sourceAuthority INTERNAL_PREREQUISITES_NOT_MET if any of dwc:decimalLatitude or dwc:decimalLongitude or dwc:countryCode are bdq:Empty; AMENDED dwc:decimalLatitude and dwc:decimalLongitude if the coordinates were transposed or one or more of the signs of the coordinates were reversed to align the location with dwc:countryCode; otherwise NOT_AMENDED INTERNAL_PREREQUISITES_NOT_MET if any of dwc:decimalLatitude or dwc:decimalLongitude or dwc:countryCode are bdq:Empty; AMENDED dwc:decimalLatitude and dwc:decimalLongitude if the coordinates were transposed or one or more of the signs of the coordinates were reversed to align the location with dwc:countryCode according to the bdq:sourceAuthority; otherwise NOT_AMENDED |
…s for two tests: tdwg/bdq#60 tdwg/bdq#54, prospectively adding handling of 'not reported' to the former.
The text was updated successfully, but these errors were encountered: