-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-AMENDMENT_TAXONRANK_STANDARDIZED #163
Comments
Added guid. |
I'd be a little bit hesitant to recommend the GBIF rank vocabulary, it is zoologically centric (there is no entry for Division, and translations of Division are mapped onto phylum, which is at the same level but isn't the same rank), most of the obscure infrasubspecific ranks found in botany are absent (particularly lusus and prolus), virological realm and subrealm are missing, etc. |
One could get propose the required changes to the GBIF vocabulary. I suspect paleo would have something to say about what is there as well. |
I agree with @tucotuco - best is to propose some changes to GBIF's vocabulary. I am sure they would be receptive. There is no good alternative that covers everything so comprehensively. Incidentally, lusus and prolus are not formal ranks under the International Code of Algae, Fungi and Plants |
@tucotuco - I also support the suggestion, and agree with @ArthurChapman that GBIF should be supportive |
All: This is a random test to demo my updates to the table fields Parameter(s), References (in this case removed as there is no additional reference/s beyond the xml end point defined in Notes) and Notes is a draft template of what we agreed. Please check and thumbs or otherwise. |
Looks OK - but in that case - that is a good reference - only other references would be to the Codes of Nomenclature and I'd prefer not to go there. Eventually, the default may be to an API, in which case you would want to retain the reference to the human readable vocabulary. |
Corrected example: dwc:taxonRecord="sp." becomes dwc:taxonRank="Species" to |
I have attempted my first addition of a Definition | Definition | An Amendment of the value in Taxon Rank to conform with the value obtained from a Paramaterized Source Authority. If no parameter is set, the source authority defaults to the latest Taxonomic Rank GBIF Vocabulary. | |
Question. Is it OK here to use "Taxon Rank" in the definition - or should it be "dwc:taxonRank. I was trying to go towards plain English, but this may not work in all cases. e.g. |
I am not convinced of the need for “Brief”. If we can’t succinctly describe it in “Description”, we fail. Why have ‘two bites at the cherry’ when one will do. Ocham’s Razor. |
@ArthurChapman I still think think that the description should not have the "single record" part in it, but I am willing to not fight it to move forward. |
IF (and to me it is a big if) 'Single record' is REQUIRED for conformance with the Framework, then surely it should be a part of the specifications - as we had it previously (as "Resource Type"). We found that all the 'tests' were "single record" so we removed it. |
Consider the following RDF:
I'm seeing a need for a label on the ContextualizedEnhancement, where the text "Description needed here" is. |
Why not "Description needed here" -> "Single record"? :) |
Looking to conform the Expected Response of AMENDMENTs to "AMEND {target} if ...", this one could become 'trivial': EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; AMEND dwc:taxonRank using bdq:sourceAuthority; otherwise NOT_AMENDED We do have the precursor #161 and #162 but we also agreed that the 'tests' should be stand-alone. Maybe the ER should be something like EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; AMEND the value of dwc:taxonRank if this value can be matched to a standard value in bdq:sourceAuthority; otherwise NOT_AMENDED ? |
Note that we have used AMENDED everywhere - not AMEND and fits with NOT_AMENDED Agree to your change - I checked all the Descriptions so that we said "value of" |
…andardized. DESCRIPTION: Minimal implmementation using hardcoded copy of current values able to match on differences in case and a few alternative text forms. Needs lookup and cache implementation and darwin cloud implementation. Working minimal implementation including unit test.
Done |
Proposal from discussion on 2022-12-11: Concern, what to do when the value is "especie", or another synonym or language variant in the specified vocabulary, expectation of amend to standard term would be that this would be that this value would be amended to "species", the standard term in the vocabulary. This could be undesirable for some users who wish to use a particular language variant for their data. Thus, similar to our handling of different national standards for geodeticDatum, proposal would be for a parameter for this, and for other amendments that conform data to a vocabulary where the parameter would allow one of three cases: (1) The amendment propose the standard term in the vocabulary, using language variants and synonyms in the vocabulary as values to be amended to the standard form, or (2) The amendment propose a particular (specified) language variant of the vocabulary term, e.g. converting all values in taxonRank to a spanish form, or (3), treating any synonym or language variant in the vocabulary as valid, and only attempting (if possible) to conform values to the vocabulary if they don't occur anywhere within it (e.g. conforming case, SPECIES to species, and ESPECIE to especie), |
Per note by @timrobertson100 in #170 we should probably switch the Source Authority to the more current, complete, and comprehensive one at https://registry.gbif.org/vocabulary/TaxonRank/concepts (available in machine readable form at https://api.gbif.org/v1/vocabularies/TaxonRank/concepts ). Likewise, we should make a similar change in #162 |
Updated "Source Authority" and "References" in accord with @chicoreus comment above. @Tasilee to check. |
Thanks @ArthurChapman: Checked. |
Could I suggest we replace the Expected response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; AMENDED the value of dwc:taxonRank if this value can be matched to a standard value in bdq:sourceAuthority; otherwise NOT_AMENDED with EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; AMENDED the value of dwc:taxonRank if it can be unambiguously matched to a term in bdq:sourceAuthority; otherwise NOT_AMENDED ? |
Is it odd that the Expected Response doesn't contain an INTERNAL_PREREQUISITES_NOT_MET? Should we have something like EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL PREREQUISITES_NOT_MET if dwc:taxonRank is EMPTY; AMENDED the value of dwc:taxonRank if it can be unambiguously matched to a term in bdq:sourceAuthority; otherwise NOT_AMENDED ? |
That would make sense to me for consistency, but without it - it still works. |
The determining factor is whether it is more appropriate to return INTERNAL PREREQUISITES_NOT_MET or NOT_AMENDED if dwc:taxonRank is EMPTY. |
I would prefer returning INTERNAL PREREQUISITES_NOT_MET. It tells you better where the test failed, not just that it did. |
OK, then I have edited the Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; AMENDED the value of dwc:taxonRank if this value can be unambiguously matched to a value in bdq:sourceAuthority; otherwise NOT_AMENDED to EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL PREREQUISITES_NOT_MET if dwc:taxonRank is EMPTY; AMENDED the value of dwc:taxonRank if it can be unambiguously matched to a term in bdq:sourceAuthority; otherwise NOT_AMENDED |
Restructured Parameter(s) and Source authority |
Post Zoom 11/7/2023, I have aligned the Source Authority with the suggested syntax: bdq:sourceAuthority default = "GBIF Vocabulary: Taxonomic Rank" [https://api.gbif.org/v1/vocabularies/TaxonRank/concepts] to bdq:sourceAuthority default = "Darwin Core" {https://dwc.tdwg.org} {dwc:taxonRank [https://dwc.tdwg.org/list/#dwc_taxonRank]} {GBIF Vocabulary: Taxonomic Rank [https://api.gbif.org/v1/vocabularies/TaxonRank/concepts]} |
On Mon, 10 Jul 2023 18:21:34 -0700 Lee Belbin ***@***.***> wrote:
Post Zoom 11/7/2023, I have aligned the Source Authority with the
suggested syntax:
bdq:sourceAuthority default = "GBIF Vocabulary: Taxonomic Rank"
[https://api.gbif.org/v1/vocabularies/TaxonRank/concepts]
This is probably a case where we do want to assert that the GBIF Vocabulary is the source authority, as it provides a controled vocabulary, while Darwin Core does not.
|
From @chicoreus's comment (#162 (comment)), changed Source Authority from bdq:sourceAuthority default = "Darwin Core" {https://dwc.tdwg.org} {dwc:taxonRank [https://dwc.tdwg.org/list/#dwc_taxonRank]} {GBIF Vocabulary: Taxonomic Rank [https://api.gbif.org/v1/vocabularies/TaxonRank/concepts]} to bdq:sourceAuthority default = "GBIF Vocabulary: Taxonomic Rank" {[https://api.gbif.org/v1/vocabularies/TaxonRank/concepts]} {dwc:taxonRank [https://dwc.tdwg.org/list/#dwc_taxonRank]} |
…pecifications. Addressed tdwg/bdq#163 AMENDMENT_TAXONRANK_STANDARDIZED Updated metadata, ProvidesVersion and Specification annotations. Removed reviewed stub method.
…pecifications. Fix for tdwg/bdq#163 AMENDMENT_TAXONRANK_STANDARDIZED not providing correct response when taxonRank is empty.
Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated" |
Changed Source Authority from bdq:sourceAuthority default = "GBIF Vocabulary: Taxonomic Rank" {[https://api.gbif.org/v1/vocabularies/TaxonRank/concepts]} {dwc:taxonRank [https://dwc.tdwg.org/list/#dwc_taxonRank]} to bdq:sourceAuthority default = "GBIF TaxonRank Vocabulary" [https://api.gbif.org/v1/vocabularies/TaxonRank]} {"dwc:taxonRank vocabulary API" [https://api.gbif.org/v1/vocabularies/TaxonRank/concepts]} |
The text was updated successfully, but these errors were encountered: