Cmake integration #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdulcet
approved these changes
Nov 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements issue #3
The CMakeLists.txt now contains two header-only targets (INTERFACE in CMake):
tglib::graphsand
tglib::tableswhich can be linked against individually.
If the project is top-level, it also compiles both exampel executables, which could be turned into tests later.
The namespace customization was done using macros at the very top of both graphs.hpp and tables.hpp using TGLIB_GRAPHS_NAMESPACE and TGLIB_TABLES_NAMESPACE respectively.
I also added C++-style include guards in the form of #pragma once to avoid duplicate symbols.